All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>, git@vger.kernel.org
Subject: Re: git clone --reference not working
Date: Thu, 17 Nov 2011 05:49:49 +0100	[thread overview]
Message-ID: <4EC4926D.5050004@alum.mit.edu> (raw)
In-Reply-To: <7vobwbpnzr.fsf@alter.siamese.dyndns.org>

On 11/17/2011 01:54 AM, Junio C Hamano wrote:
> Andrea Arcangeli <aarcange@redhat.com> writes:
> 
>> latest git.git won't clone linux upstream with --reference. Those
>> v*^{} tags breaks it. What's that stuff anyway, looks totally ugly
>> (two commits with same data contents and header) bah.
> 
> They point at commits they tag, and are essential for auto-following. They
> have been there forever in ls-remote output and they are not the real
> problem.
> 
> A recent topic that was merged at 9bd5000 tightened the refname checking
> code without thinking and started to needlessly barf upon seeing them. I
> think we have discussed about the issue on the list, but I do not think
> there were fixes yet.
> 
> Thanks for reminding.
> 
> Michael, how does this look?
>
> -- >8 --
> Subject: refs: loosen over-strict "format" check
> [...]

I reviewed the patch (and ran the test suite here for good measure).
Looks good.

>From SubmittingPatches it looks like I should authorize

Reviewed-by: Michael Haggerty <mhagger@alum.mit.edu>

Is there a standard way to do so?

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/

  reply	other threads:[~2011-11-17  4:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20111116234314.GF3306@redhat.com>
2011-11-17  0:54 ` git clone --reference not working Junio C Hamano
2011-11-17  4:49   ` Michael Haggerty [this message]
2011-11-17  5:55     ` Junio C Hamano
2011-11-17 14:56       ` Michael Haggerty
2011-11-17 17:40         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EC4926D.5050004@alum.mit.edu \
    --to=mhagger@alum.mit.edu \
    --cc=aarcange@redhat.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.