Re: [Qemu-devel] [PATCH 1/4] Makefile: remove more generated files on clean

[Paolo Bonzini <pbonzini@redhat.com>]

On 11/16/2011 10:58 PM, Michael S. Tsirkin wrote:
> make clean missed the source qmp files generated
> by python. Fix that.
>
> Signed-off-by: Michael S. Tsirkin<mst@redhat.com>
> ---
>   Makefile |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 168093c..b335f2a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -8,6 +8,7 @@ ifeq ($(TRACE_BACKEND),dtrace)
>   GENERATED_HEADERS += trace-dtrace.h
>   endif
>   GENERATED_HEADERS += qmp-commands.h qapi-types.h qapi-visit.h
> +GENERATED_SOURCES += qmp-marshal.c qapi-types.c qapi-visit.c
>
>   ifneq ($(wildcard config-host.mak),)
>   # Put the all: rule here so that config-host.mak can contain dependencies.
> @@ -227,6 +228,7 @@ clean:
>   	rm -f trace.c trace.h trace.c-timestamp trace.h-timestamp
>   	rm -f trace-dtrace.dtrace trace-dtrace.dtrace-timestamp
>   	rm -f trace-dtrace.h trace-dtrace.h-timestamp
> +	rm -f $(GENERATED_SOURCES)
>   	rm -rf $(qapi-dir)
>   	$(MAKE) -C tests clean
>   	for d in $(ALL_SUBDIRS) $(QEMULIBS) libcacard; do \

Series looks good,

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo