From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [patch 2/2] [PATCH] kvm-s390: pseudo page fault support
Date: Thu, 17 Nov 2011 16:13:25 +0100
Message-ID: <4EC52495.3090207@de.ibm.com>
References: <20111117111954.130341385@de.ibm.com> <20111117112248.205248622@de.ibm.com> <4EC5098B.70101@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Carsten Otte <cotte@de.ibm.com>,
	Marcelo Tossati <mtosatti@redhat.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Cornelia Huck <cornelia.huck@de.ibm.com>,
	KVM <kvm@vger.kernel.org>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mtagate2.uk.ibm.com ([194.196.100.162]:37042 "EHLO
	mtagate2.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757785Ab1KQPNa (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 17 Nov 2011 10:13:30 -0500
Received: from d06nrmr1707.portsmouth.uk.ibm.com (d06nrmr1707.portsmouth.uk.ibm.com [9.149.39.225])
	by mtagate2.uk.ibm.com (8.13.1/8.13.1) with ESMTP id pAHFDSlG032541
	for <kvm@vger.kernel.org>; Thu, 17 Nov 2011 15:13:28 GMT
Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248])
	by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pAHFDSwH2142326
	for <kvm@vger.kernel.org>; Thu, 17 Nov 2011 15:13:28 GMT
Received: from d06av07.portsmouth.uk.ibm.com (loopback [127.0.0.1])
	by d06av07.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pAHFDRKx024040
	for <kvm@vger.kernel.org>; Thu, 17 Nov 2011 08:13:27 -0700
In-Reply-To: <4EC5098B.70101@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

>> +	VCPU_EVENT(vcpu, 5, "synchronous page fault at guest %lx user %lx",
>> +		   current->thread.gmap_addr, uaddr);
>> +
>> +	fault_in_pages_readable((char __user *)uaddr, PAGE_SIZE);
>> +}
> 
> These may make sense as tracepoints (this is what x86 does).  The
> kvm_stat script knows how to pick them up and generate an event
> histogram dynamically, along with all the other goodies tracepoints bring.

Coverting these to trace points is on my todo list.