From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gerlando Falauto <gerlando.falauto@keymile.com>
Date: Thu, 17 Nov 2011 19:47:23 +0100
Subject: [U-Boot] [PATCH] env: allow to export only selected variables
In-Reply-To: <1320754970-26150-1-git-send-email-wd@denx.de>
References: <1320754970-26150-1-git-send-email-wd@denx.de>
Message-ID: <4EC556BB.7030600@keymile.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Wolfgang Denk,

> --- a/common/cmd_nvedit.c
> +++ b/common/cmd_nvedit.c
> @@ -125,7 +125,7 @@ static int env_print(char *name)
>   	}
>
>   	/* print whole list */
> -	len = hexport_r(&env_htab, '\n',&res, 0);
> +	len = hexport_r(&env_htab, '\n',&res, 0, 0, NULL);
>
>   	if (len>  0) {
>   		puts(res);

Here you extended the function signature by adding 2 new arguments and 
therefore you had to touch 12 existing function calls so to add the 
default values for the new args.

In my previous patches, I had renamed the sibling himport_r() function 
to himport_ex() with the 2 extra args and reimplemented himport_r() as a 
wrapper, so to maintain compatibility with the existing code.
Just to realize now that, after some reworking, there is only one 
function call to the original himport_r() left.
I'm going to get rid of this renaming.

I mean: completely opposite approaches... funny, huh?

Best,
Gerlando Falauto