From: Viresh Kumar <viresh.kumar@st.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: "baruch@tkos.co.il" <baruch@tkos.co.il>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Armando VISCONTI <armando.visconti@st.com>,
Shiraz HASHIM <shiraz.hashim@st.com>,
Vipin KUMAR <vipin.kumar@st.com>,
Rajeev KUMAR <rajeev-dlh.kumar@st.com>,
Deepak SIKRI <deepak.sikri@st.com>,
Vipul Kumar SAMAR <vipulkumar.samar@st.com>,
Amit VIRDI <Amit.VIRDI@st.com>,
Pratyush ANAND <pratyush.anand@st.com>,
Bhupesh SHARMA <bhupesh.sharma@st.com>,
"viresh.linux@gmail.com" <viresh.linux@gmail.com>,
Bhavna YADAV <bhavna.yadav@st.com>,
Vincenzo FRASCINO <Vincenzo.FRASCINO@st.com>,
Mirko GARDI <mirko.gardi@st.com>
Subject: Re: [PATCH] GPIO/pl061: Add suspend resume capability
Date: Fri, 18 Nov 2011 09:32:56 +0530 [thread overview]
Message-ID: <4EC5D8F0.3040905@st.com> (raw)
In-Reply-To: <201111172134.31591.rjw@sisk.pl>
On 11/18/2011 2:04 AM, Rafael J. Wysocki wrote:
>> > +static const struct dev_pm_ops pl061_dev_pm_ops = {
>> > + .suspend = pl061_suspend,
>> > + .resume = pl061_resume,
> Please also include hibernation callbacks here, otherwise your code will
> break systems with hibernation enabled.
>
> There are convenience macros for that in linux/pm.h, please use one of them.
Sure. Thanx.
--
viresh
prev parent reply other threads:[~2011-11-18 4:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 11:15 [PATCH] GPIO/pl061: Add suspend resume capability Viresh Kumar
2011-11-17 13:54 ` Baruch Siach
2011-11-18 3:30 ` Viresh Kumar
2011-11-17 20:34 ` Rafael J. Wysocki
2011-11-18 4:02 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC5D8F0.3040905@st.com \
--to=viresh.kumar@st.com \
--cc=Amit.VIRDI@st.com \
--cc=Vincenzo.FRASCINO@st.com \
--cc=armando.visconti@st.com \
--cc=baruch@tkos.co.il \
--cc=bhavna.yadav@st.com \
--cc=bhupesh.sharma@st.com \
--cc=deepak.sikri@st.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=mirko.gardi@st.com \
--cc=pratyush.anand@st.com \
--cc=rajeev-dlh.kumar@st.com \
--cc=rjw@sisk.pl \
--cc=shiraz.hashim@st.com \
--cc=vipin.kumar@st.com \
--cc=vipulkumar.samar@st.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.