Re: [Qemu-devel] [PATCH] virtio-blk: fix cross-endian config space

[Kevin Wolf <kwolf@redhat.com>]

Am 15.11.2011 12:07, schrieb Paolo Bonzini:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hw/virtio-blk.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c
> index 01aeb28..4a15f0c 100644
> --- a/hw/virtio-blk.c
> +++ b/hw/virtio-blk.c
> @@ -481,14 +481,14 @@ static void virtio_blk_update_config(VirtIODevice *vdev, uint8_t *config)
>      stq_raw(&blkcfg.capacity, capacity);
>      stl_raw(&blkcfg.seg_max, 128 - 2);
>      stw_raw(&blkcfg.cylinders, cylinders);
> +    stl_raw(&blkcfg.blk_size, s->conf->logical_block_size);
> +    stw_raw(&blkcfg.min_io_size, s->conf->min_io_size / blkcfg.blk_size);
> +    stw_raw(&blkcfg.opt_io_size, s->conf->opt_io_size / blkcfg.blk_size);

blkcfg.blk_size is in target endianness now, so you can't use it in the
calculation for min/opt_io_size any more.

Kevin