From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RROqf-0004wy-GT for qemu-devel@nongnu.org; Fri, 18 Nov 2011 08:51:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RROqb-0000rg-R9 for qemu-devel@nongnu.org; Fri, 18 Nov 2011 08:51:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57337) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RROqb-0000rC-K3 for qemu-devel@nongnu.org; Fri, 18 Nov 2011 08:51:17 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pAIDpENU014168 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 18 Nov 2011 08:51:15 -0500 Message-ID: <4EC662D0.1020406@redhat.com> Date: Fri, 18 Nov 2011 14:51:12 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1321277512-9414-1-git-send-email-pbonzini@redhat.com> <1321277512-9414-4-git-send-email-pbonzini@redhat.com> <4EC658A4.5000404@redhat.com> In-Reply-To: <4EC658A4.5000404@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 3/6] scsi: fix parsing of allocation length field List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On 11/18/2011 02:07 PM, Kevin Wolf wrote: >> > - cmd->xfer = ldl_be_p(&buf[10]); >> > + cmd->xfer = ldl_be_p(&buf[10])& 0xffffffffULL; > Makes me wonder why we don't have an unsigned version of ldl_be_p... Yes, that was on my list for 1.1. Paolo