From: David Daney <ddaney.cavm@gmail.com>
To: Sergei Shtylyov <sshtylyov@mvista.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org,
linux-kernel@vger.kernel.org,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH v2 2/2] hugetlb: Provide safer dummy values for HPAGE_MASK and HPAGE_SIZE
Date: Fri, 18 Nov 2011 09:14:17 -0800 [thread overview]
Message-ID: <4EC69269.7060505@gmail.com> (raw)
In-Reply-To: <4EC61DB1.3090608@mvista.com>
On 11/18/2011 12:56 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 18-11-2011 1:57, David Daney wrote:
>
>> From: David Daney<david.daney@cavium.com>
>
>> It was pointed out by David Rientjes that the dummy values for
>> HPAGE_MASK and HPAGE_SIZE are quite unsafe. It they are inadvertently
>> used with !CONFIG_HUGETLB_PAGE, compilation would succeed, but the
>> resulting code would surly not do anything sensible.
>>
>> Place BUG() in the these dummy definitions, as we do in similar
>> circumstances in other places, so any abuse can be easily detected.
>>
>> Since the only sane place to use these symbols when
>> !CONFIG_HUGETLB_PAGE is on dead code paths, the BUG() cause any actual
>> code to be emitted by the compiler.
>
> You mean "doesn't cause"?
Yes.
I mentioned this in a different message to akpm, but I am not sure if I
should resend the patch with a corrected change log.
David Daney
>
>> Cc: David Rientjes<rientjes@google.com>
>> Signed-off-by: David Daney<david.daney@cavium.com>
>
> WBR, Sergei
>
>
next prev parent reply other threads:[~2011-11-18 17:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 21:57 [PATCH v2 0/2] Dummy HPAGE_* constants for !CONFIG_HUGETLB_PAGE David Daney
2011-11-17 21:57 ` [PATCH v2 1/2] hugetlb: Provide a default HPAGE_SHIFT if !CONFIG_HUGETLB_PAGE David Daney
2011-11-17 21:57 ` [PATCH v2 2/2] hugetlb: Provide safer dummy values for HPAGE_MASK and HPAGE_SIZE David Daney
2011-11-17 23:28 ` Andrew Morton
2011-11-17 23:38 ` David Daney
2011-11-18 8:56 ` Sergei Shtylyov
2011-11-18 17:14 ` David Daney [this message]
2011-11-17 23:22 ` [PATCH v2 0/2] Dummy HPAGE_* constants for !CONFIG_HUGETLB_PAGE David Rientjes
2011-11-17 23:22 ` [patch] hugetlb: remove dummy definitions of HPAGE_MASK and HPAGE_SIZE David Rientjes
2011-11-17 23:35 ` Andrew Morton
2011-11-17 23:44 ` David Rientjes
2011-11-17 23:52 ` David Daney
2011-11-17 23:57 ` Andrew Morton
2011-11-17 23:57 ` David Rientjes
2011-11-21 22:23 ` David Daney
2011-11-21 22:43 ` Linus Torvalds
2011-11-21 23:23 ` David Daney
2011-11-21 23:43 ` Linus Torvalds
2011-11-21 23:50 ` Andrew Morton
2011-11-22 20:41 ` Andi Kleen
2011-11-22 20:41 ` Andi Kleen
2011-11-21 23:47 ` David Daney
2011-11-21 23:53 ` Andrew Morton
2011-11-22 0:37 ` Linus Torvalds
2011-11-22 0:48 ` David Daney
2011-11-22 0:55 ` Linus Torvalds
2011-11-21 22:48 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC69269.7060505@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david.daney@cavium.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.