From: Hauke Mehrtens <hauke@hauke-m.de>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org,
"Luis R. Rodriguez" <lrodriguez@qca.qualcomm.com>
Subject: Re: [PATCH 1/2] compat: avoid warning in compat_system_workqueue_create
Date: Fri, 18 Nov 2011 20:24:58 +0100 [thread overview]
Message-ID: <4EC6B10A.5020907@hauke-m.de> (raw)
In-Reply-To: <1321490374-24529-1-git-send-email-linville@tuxdriver.com>
On 11/17/2011 01:39 AM, John W. Linville wrote:
> The check in the WARN_ON is inverted.
>
Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> compat/compat-2.6.36.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/compat/compat-2.6.36.c b/compat/compat-2.6.36.c
> index aab25df..fe24da8 100644
> --- a/compat/compat-2.6.36.c
> +++ b/compat/compat-2.6.36.c
> @@ -99,7 +99,7 @@ EXPORT_SYMBOL_GPL(system_nrt_wq);
> void compat_system_workqueue_create()
> {
> system_nrt_wq = create_singlethread_workqueue("events_nrt");
> - WARN_ON(system_nrt_wq);
> + WARN_ON(!system_nrt_wq);
> }
>
> void compat_system_workqueue_destroy()
That was my fault, please apply this patch.
Hauke
next prev parent reply other threads:[~2011-11-18 19:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 0:39 [PATCH 1/2] compat: avoid warning in compat_system_workqueue_create John W. Linville
2011-11-17 0:39 ` [PATCH 2/2] compat: implement dummy security_sk_clone John W. Linville
2011-11-18 19:37 ` Hauke Mehrtens
2011-11-18 20:53 ` John W. Linville
2011-11-18 19:24 ` Hauke Mehrtens [this message]
2011-11-18 19:32 ` [PATCH 1/2] compat: avoid warning in compat_system_workqueue_create Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC6B10A.5020907@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.