All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tabi Timur-B04825 <B04825@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc/85xx: clean up and document the QE/FMAN microcode macros
Date: Sat, 19 Nov 2011 17:18:58 +0000	[thread overview]
Message-ID: <4EC7E500.1040602@freescale.com> (raw)
In-Reply-To: <6E420F0A-8A23-454F-AC69-96E91E8166C1@freescale.com>

Kumar Gala wrote:
>> >  #ifdef CONFIG_QE
>> >  /* QE microcode/firmware address */
>> >  -#define CONFIG_SYS_QE_FW_ADDR		0xefec0000
>> >  -#define CONFIG_SYS_QE_FW_LENGTH		0x10000
>> >  +#define CONFIG_SYS_QE_FMAN_FW_IN_NOR
>> >  +#define CONFIG_SYS_QE_FMAN_FW_ADDR	0xefec0000
>> >  +#define CONFIG_SYS_QE_FMAN_FW_LENGTH	0x10000
> this is wrong, there is no FMAN on this device.

Macros that have "QE_FMAN" are used for QE and Fman.  Does this device 
have a QE?

Keep in mind that I'm just cleaning up existing usage.  I'm not adding any 
functionality to any board.

-- 
Timur Tabi
Linux kernel developer at Freescale

  reply	other threads:[~2011-11-19 17:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-08 23:40 [U-Boot] [PATCH] powerpc/85xx: clean up and document the QE/FMAN microcode macros Timur Tabi
2011-11-19 17:16 ` Kumar Gala
2011-11-19 17:18   ` Tabi Timur-B04825 [this message]
2011-11-22 12:54 ` Kumar Gala
2011-11-22 14:16   ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EC7E500.1040602@freescale.com \
    --to=b04825@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.