From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Tobias Schandinat Date: Sun, 20 Nov 2011 01:50:33 +0000 Subject: Re: [PATCH 5/5] Drivers: video: riva: riva_hw: fixed a brace coding Message-Id: <4EC85CE9.6060706@gmx.de> List-Id: References: <1321591537-8475-1-git-send-email-zac.3.14159@gmail.com> In-Reply-To: <1321591537-8475-1-git-send-email-zac.3.14159@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Zac Storer Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org On 11/18/2011 04:45 AM, Zac Storer wrote: > Fixed a brace coding style issue. *sigh* You are fixing coding style, but I still get lots of warnings for the single line you are changing. IF you are fixing coding style, at least do it right. Or do you really expect me to be happy if you send me 3 patches that all touch the same line? Really, if you want to fix it, at least fix it in a way that checkpatch.pl does no longer complain about your patch, at least regarding coding style issues. And for such patches I think a per file patch or similar would be appropriate. Regards, Florian Tobias Schandinat > > Signed-off-by: Zac Storer > --- > drivers/video/riva/riva_hw.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/riva/riva_hw.c b/drivers/video/riva/riva_hw.c > index 78fdbf5..c4b8a6f 100644 > --- a/drivers/video/riva/riva_hw.c > +++ b/drivers/video/riva/riva_hw.c > @@ -994,7 +994,7 @@ static void nv10CalcArbitration > clwm = clwm_mt; > */ > /* Finally, a heuristic check when width = 64 bits */ > - if(width = 1){ > + if(width = 1) { > nvclk_fill = nvclk_freq * 8; > if(crtc_drain_rate * 100 >= nvclk_fill * 102) > clwm = 0xfff; /*Large number to fail */ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754597Ab1KTBuh (ORCPT ); Sat, 19 Nov 2011 20:50:37 -0500 Received: from mailout-de.gmx.net ([213.165.64.23]:38801 "HELO mailout-de.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752963Ab1KTBuf (ORCPT ); Sat, 19 Nov 2011 20:50:35 -0500 X-Authenticated: #10250065 X-Provags-ID: V01U2FsdGVkX18w9Oow5zcw3LYIr6L0uMf+La54Ftbm7G4pUtHHo4 nXumRC0tzNkRFT Message-ID: <4EC85CE9.6060706@gmx.de> Date: Sun, 20 Nov 2011 01:50:33 +0000 From: Florian Tobias Schandinat User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20111004 Icedove/3.0.11 MIME-Version: 1.0 To: Zac Storer CC: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] Drivers: video: riva: riva_hw: fixed a brace coding style issue References: <1321591537-8475-1-git-send-email-zac.3.14159@gmail.com> In-Reply-To: <1321591537-8475-1-git-send-email-zac.3.14159@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/18/2011 04:45 AM, Zac Storer wrote: > Fixed a brace coding style issue. *sigh* You are fixing coding style, but I still get lots of warnings for the single line you are changing. IF you are fixing coding style, at least do it right. Or do you really expect me to be happy if you send me 3 patches that all touch the same line? Really, if you want to fix it, at least fix it in a way that checkpatch.pl does no longer complain about your patch, at least regarding coding style issues. And for such patches I think a per file patch or similar would be appropriate. Regards, Florian Tobias Schandinat > > Signed-off-by: Zac Storer > --- > drivers/video/riva/riva_hw.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/riva/riva_hw.c b/drivers/video/riva/riva_hw.c > index 78fdbf5..c4b8a6f 100644 > --- a/drivers/video/riva/riva_hw.c > +++ b/drivers/video/riva/riva_hw.c > @@ -994,7 +994,7 @@ static void nv10CalcArbitration > clwm = clwm_mt; > */ > /* Finally, a heuristic check when width == 64 bits */ > - if(width == 1){ > + if(width == 1) { > nvclk_fill = nvclk_freq * 8; > if(crtc_drain_rate * 100 >= nvclk_fill * 102) > clwm = 0xfff; /*Large number to fail */