From: Sylwester Nawrocki <snjw23@gmail.com>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Thomas Jarosch <thomas.jarosch@intra2net.com>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org,
"HeungJun Kim/Mobile S/W Platform Lab(DMC)/E3"
<riverful.kim@samsung.com>
Subject: Re: [PATCH resent] Fix logic in sanity check
Date: Sun, 20 Nov 2011 18:26:13 +0100 [thread overview]
Message-ID: <4EC93835.7010200@gmail.com> (raw)
In-Reply-To: <4EB3AD88.1090702@samsung.com>
Hi,
On 11/04/2011 10:16 AM, Sylwester Nawrocki wrote:
> On 10/15/2011 11:38 PM, Thomas Jarosch wrote:
>> Detected by "cppcheck".
>>
>> This time with "Signed-off-by" line.
When a note like this is added, not suitable for the changelog,
it should be placed after your SOB line, and below a line containing
only the "---" marker. Please check with Documentation/SubmittingPatches
for more details.
>>
>> Signed-off-by: Thomas Jarosch<thomas.jarosch@intra2net.com>
>
> Acked-by: Sylwester Nawrocki<s.nawrocki@samsung.com>
Sorry, I was a bit too quick with this ack.
If you care to resend the patch, please add "m5mols:" as a subsystem name
in the subject so it looks something like:
[PATCH ...] m5mols: Fix ...
>
>> ---
>> drivers/media/video/m5mols/m5mols_core.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
--
Thanks,
Sylwester
next prev parent reply other threads:[~2011-11-20 17:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-15 21:38 [PATCH resent] Fix logic in sanity check Thomas Jarosch
2011-11-04 9:16 ` Sylwester Nawrocki
2011-11-20 17:26 ` Sylwester Nawrocki [this message]
2011-11-29 12:26 ` Thomas Jarosch
2011-11-29 16:56 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC93835.7010200@gmail.com \
--to=snjw23@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=riverful.kim@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=thomas.jarosch@intra2net.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.