From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ilya Yanok Subject: Re: [PATCH] edt_ts: EDT Touchscreen driver Date: Sun, 20 Nov 2011 22:09:24 +0400 Message-ID: <4EC94254.8000700@emcraft.com> References: <1320795279-2018-1-git-send-email-yanok@emcraft.com> <20111114172809.GD12659@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from ocean.emcraft.com ([213.221.7.182]:58808 "EHLO ocean.emcraft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752530Ab1KTSJS (ORCPT ); Sun, 20 Nov 2011 13:09:18 -0500 In-Reply-To: <20111114172809.GD12659@core.coreip.homeip.net> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, wd@denx.de, dzu@denx.de, sasha_d@emcraft.com, Anatolij Gustshin Hi Dmitry, one quick question before I repost the updated patch: On 14.11.2011 21:28, Dmitry Torokhov wrote: >> +err0: >> + dev_set_drvdata(&client->dev, NULL); > > Not needed. Do you really think leaving a pointer to a non-existing structure is a good idea? Regards, Ilya.