All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@xenotime.net>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Dmitry Kasatkin <dmitry.kasatkin@intel.com>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: [PATCH -next] digsig: fix build errors
Date: Sun, 20 Nov 2011 22:12:34 -0800	[thread overview]
Message-ID: <4EC9EBD2.3040708@xenotime.net> (raw)
In-Reply-To: <20111121133936.ae0ecadbf39ae50da6b842d1@canb.auug.org.au>

From: Randy Dunlap <rdunlap@xenotime.net>

Fix build errors by adding kconfig dependency on KEYS:

lib/digsig.c:106:16: error: dereferencing pointer to incomplete type
lib/digsig.c:107:11: error: dereferencing pointer to incomplete type
lib/digsig.c:184:14: error: dereferencing pointer to incomplete type
lib/digsig.c:223:3: error: 'key_ref_t' undeclared (first use in this function)
lib/digsig.c:223:13: error: expected ';' before 'kref'
lib/digsig.c:224:3: error: 'kref' undeclared (first use in this function)
lib/digsig.c:224:3: error: implicit declaration of function 'keyring_search'
lib/digsig.c:231:3: error: implicit declaration of function 'request_key'

and after changing lib/Kconfig:
warning: (INTEGRITY_DIGSIG) selects DIGSIG which has unmet direct dependencies (CRYPTO && KEYS)

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Cc: Dmitry Kasatkin <dmitry.kasatkin@intel.com>
---
 lib/Kconfig                |    4 ++--
 security/integrity/Kconfig |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

--- next-2011-1121.orig/lib/Kconfig
+++ next-2011-1121/lib/Kconfig
@@ -294,10 +294,10 @@ config MPILIB_EXTRA
 
 config DIGSIG
 	tristate "In-kernel signature checker"
-	depends on CRYPTO
+	depends on CRYPTO && KEYS
 	select MPILIB
 	help
 	  Digital signature verification. Currently only RSA is supported.
-	  Implementation is done using GnuPG MPI library
+	  Implementation is done using GnuPG MPI library.
 
 endmenu
--- next-2011-1121.orig/security/integrity/Kconfig
+++ next-2011-1121/security/integrity/Kconfig
@@ -5,7 +5,7 @@ config INTEGRITY
 
 config INTEGRITY_DIGSIG
 	boolean "Digital signature verification using multiple keyrings"
-	depends on INTEGRITY
+	depends on INTEGRITY && CRYPTO && KEYS
 	default n
 	select DIGSIG
 	help

  reply	other threads:[~2011-11-21  6:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-21  2:39 linux-next: Tree for Nov 21 Stephen Rothwell
2011-11-21  6:12 ` Randy Dunlap [this message]
2011-11-21 10:32   ` [PATCH -next] digsig: fix build errors Kasatkin, Dmitry
2011-11-21 15:52     ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EC9EBD2.3040708@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=dmitry.kasatkin@intel.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.