All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Hillf Danton <dhillf@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
	David Daney <david.daney@cavium.com>,
	"Jayachandran C." <jayachandranc@netlogicmicro.com>,
	linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: Flush huge TLB
Date: Mon, 21 Nov 2011 14:48:07 +0400	[thread overview]
Message-ID: <4ECA2C67.9040406@mvista.com> (raw)
In-Reply-To: <CAJd=RBBTx8zWrFfVQGMK=aj=iPO_+i6nvqkhGDfYp_9=d1hyEw@mail.gmail.com>

Hello.

On 18-11-2011 17:15, Hillf Danton wrote:

> When flushing TLB, if @vma is backed by huge page, we could flush huge TLB,
> due to that huge page is defined to be far from normal page.

> Signed-off-by: Hillf Danton<dhillf@gmail.com>
> ---

> --- a/arch/mips/mm/tlb-r4k.c	Mon May 30 21:17:04 2011
> +++ b/arch/mips/mm/tlb-r4k.c	Fri Nov 18 21:13:13 2011
> @@ -120,22 +120,30 @@ void local_flush_tlb_range(struct vm_are
[...]
>   				write_c0_entryhi(start | newpid);
> -				start += (PAGE_SIZE<<  1);
> +				if (huge)
> +					start += HPAGE_SIZE;
> +				else
> +					start += (PAGE_SIZE << 1);

    Parens not needed.

WBR, Sergei

      parent reply	other threads:[~2011-11-21 10:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-18 13:15 [PATCH] MIPS: Flush huge TLB Hillf Danton
2011-11-18 14:46 ` Ralf Baechle
2011-11-18 14:55   ` Hillf Danton
2011-11-21 10:48 ` Sergei Shtylyov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ECA2C67.9040406@mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=david.daney@cavium.com \
    --cc=dhillf@gmail.com \
    --cc=jayachandranc@netlogicmicro.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.