From: David Daney <ddaney.cavm@gmail.com>
To: Hillf Danton <dhillf@gmail.com>
Cc: David Rientjes <rientjes@google.com>,
Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch] mips, mm: avoid using HPAGE constants without CONFIG_HUGETLB_PAGE
Date: Mon, 21 Nov 2011 11:25:44 -0800 [thread overview]
Message-ID: <4ECAA5B8.3080908@gmail.com> (raw)
In-Reply-To: <CAJd=RBBmODwpUi1_eObE47yCQVfEGLHyy45=aqUtxM-9Bpki6A@mail.gmail.com>
On 11/19/2011 09:27 PM, Hillf Danton wrote:
[...]
>
> --- a/arch/mips/include/asm/page.h Sun Nov 20 13:08:44 2011
> +++ b/arch/mips/include/asm/page.h Sun Nov 20 13:17:43 2011
> @@ -38,6 +38,11 @@
> #define HPAGE_SIZE (_AC(1,UL)<< HPAGE_SHIFT)
> #define HPAGE_MASK (~(HPAGE_SIZE - 1))
> #define HUGETLB_PAGE_ORDER (HPAGE_SHIFT - PAGE_SHIFT)
> +#else
> +#define HPAGE_SHIFT ({ BUG(); 0; })
> +#define HPAGE_SIZE ({ BUG(); 0; })
> +#define HPAGE_MASK ({ BUG(); 0; })
These three are taken care of in linux/hugetlb.h by the patches that
Andrew Morton has in his tree, the full discussion starts at:
http://www.linux-mips.org/archives/linux-mips/2011-11/msg00412.html
> +#define HUGETLB_PAGE_ORDER ({ BUG(); 0; })
This value doesn't appear to be necessary at this point.
David Daney
next prev parent reply other threads:[~2011-11-21 19:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-20 2:56 [patch] mips, mm: avoid using HPAGE constants without CONFIG_HUGETLB_PAGE David Rientjes
2011-11-20 5:27 ` Hillf Danton
2011-11-21 19:25 ` David Daney [this message]
2011-11-21 22:31 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECAA5B8.3080908@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dhillf@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.