Re: PATCH 12/13: 0012-CXD2820r-Query-DVB-frontend-delivery-capabilities

[Antti Palosaari <crope@iki.fi>]

Hello

On 11/21/2011 11:09 PM, Manu Abraham wrote:
>   	/* program tuner */
> -	if (fe->ops.tuner_ops.set_params)
> -		fe->ops.tuner_ops.set_params(fe, params);
> +	tstate.delsys = SYS_DVBC_ANNEX_AC;
> +	tstate.frequency = c->frequency;
> +
> +	if (fe->ops.tuner_ops.set_state) {
> +		fe->ops.tuner_ops.set_state(fe,
> +					    DVBFE_TUNER_DELSYS    |
> +					    DVBFE_TUNER_FREQUENCY,
> +					&tstate);

I want to raise that point, switch from .set_params() to .set_state() 
when programming tuner. I don't see it reasonable to introduce (yes, it 
have existed ages but not used) new way to program tuner.

Both demod and tuner got same params;
.set_frontend(struct dvb_frontend *, struct dvb_frontend_parameters *)
.set_params(struct dvb_frontend *, struct dvb_frontend_parameters *)

and can get access to APIv5 property_cache similarly. Both, demod and 
tuner, can read all those params that are now passed using .set_state()

There is some new tuner drivers which are already using APIv5.


regards
Antti

-- 
http://palosaari.fi/