All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boaz Harrosh <bharrosh@panasas.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] exofs: fix endian conversion in exofs_sync_fs()
Date: Tue, 22 Nov 2011 00:57:23 +0000	[thread overview]
Message-ID: <4ECAF373.1060708@panasas.com> (raw)
In-Reply-To: <20111121144311.GA19025@elgon.mountain>

On 11/21/2011 06:43 AM, Dan Carpenter wrote:
> fscb->s_numfiles is an __le64 field so we need to use cpu_to_le64()
> to get a little endian 64 bit on big endian systems.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> This is a static checker fix.  Untested.
> 

Will apply. s_numfiles is never used but should be loaded
correctly regardless.

Thanks
Boaz

> diff --git a/fs/exofs/super.c b/fs/exofs/super.c
> index e6085ec..53b55a3 100644
> --- a/fs/exofs/super.c
> +++ b/fs/exofs/super.c
> @@ -390,7 +390,7 @@ static int exofs_sync_fs(struct super_block *sb, int wait)
>  	ios->length = offsetof(struct exofs_fscb, s_dev_table_oid);
>  	memset(fscb, 0, ios->length);
>  	fscb->s_nextid = cpu_to_le64(sbi->s_nextid);
> -	fscb->s_numfiles = cpu_to_le32(sbi->s_numfiles);
> +	fscb->s_numfiles = cpu_to_le64(sbi->s_numfiles);
>  	fscb->s_magic = cpu_to_le16(sb->s_magic);
>  	fscb->s_newfs = 0;
>  	fscb->s_version = EXOFS_FSCB_VER;


  reply	other threads:[~2011-11-22  0:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-21 14:43 [patch] exofs: fix endian conversion in exofs_sync_fs() Dan Carpenter
2011-11-22  0:57 ` Boaz Harrosh [this message]
2012-01-29 14:25 ` Dan Carpenter
2012-01-29 14:29 ` Dan Carpenter
2012-01-30 13:45 ` Boaz Harrosh
2012-01-30 13:58 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ECAF373.1060708@panasas.com \
    --to=bharrosh@panasas.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.