From: Vincent van Ravesteijn <vfr@lyx.org>
To: Sebastian Schuberth <sschuberth@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com, kusmabite@gmail.com,
msysgit@googlegroups.com, j.sixt@viscovery.net,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 2/3] Compile fix for MSVC: fix poll-related macro redefines
Date: Tue, 22 Nov 2011 08:30:00 +0100 [thread overview]
Message-ID: <4ECB4F78.40309@lyx.org> (raw)
In-Reply-To: <4EC6978D.3020604@gmail.com>
Op 18-11-2011 18:36, Sebastian Schuberth schreef:
> On 18.11.2011 17:44, Vincent van Ravesteijn wrote:
>
>> diff --git a/git-compat-util.h b/git-compat-util.h
>> index 5ef8ff7..76cbfe6 100644
>> --- a/git-compat-util.h
>> +++ b/git-compat-util.h
>> @@ -85,6 +85,7 @@
>> #define _SGI_SOURCE 1
>>
>> #ifdef WIN32 /* Both MinGW and MSVC */
>> +# define _WIN32_WINNT 0x0501
>> #define WIN32_LEAN_AND_MEAN /* stops windows.h including winsock.h */
>> #include<winsock2.h>
>> #include<windows.h>
>
> It seems the indentation is wrong (does not match the surrounding
> code) here.
>
Yes, you're right. I will reroll the patch series when there is somewhat
more feedback on the series.
Vincent
next prev parent reply other threads:[~2011-11-22 7:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 16:44 [PATCH 1/3] MSVC: Remove vcbuild/include/sys/poll.h Vincent van Ravesteijn
2011-11-18 16:44 ` [PATCH 2/3] Compile fix for MSVC: fix poll-related macro redefines Vincent van Ravesteijn
2011-11-18 17:36 ` Sebastian Schuberth
2011-11-22 7:30 ` Vincent van Ravesteijn [this message]
2011-11-18 16:44 ` [PATCH 3/3] Compile fix for MSVC: Use NO_INET_PTON and NO_INET_NTOP Vincent van Ravesteijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECB4F78.40309@lyx.org \
--to=vfr@lyx.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=johannes.schindelin@gmx.de \
--cc=kusmabite@gmail.com \
--cc=msysgit@googlegroups.com \
--cc=sschuberth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.