From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Frank Rysanek <rysanek@fccps.cz>,
Pavel Cheblakov <P.B.Cheblakov@inp.nsk.su>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
Wolfgang Grandegger <wg@grandegger.com>
Subject: Re: [RFC PATCH] plx_pci: add Advantech PCI-1680 & UNO-2052 support
Date: Tue, 22 Nov 2011 10:09:38 +0100 [thread overview]
Message-ID: <4ECB66D2.6030108@pengutronix.de> (raw)
In-Reply-To: <4ECAB5E4.6010903@hartkopp.net>
[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]
On 11/21/2011 09:34 PM, Oliver Hartkopp wrote:
> Add Advantech PCI-1680 & UNO-2052 support for the SJA1000 plx_pci driver.
>
> Signed-off-by: Frank Rysanek <rysanek@fccps.cz>
Nitpick: When posting this patch to netdev don't forget to add your
S-o-b line.
>
> ---
>
> Hello Frank,
>
> i found your patch to support the Advantech PCI-1680 & UNO-2052 cards here:
>
> http://www.fccps.cz/download/adv/frr/can-notes.html
>
> Are you fine with posting the changes on the netdev mailing list to become
> part of the mainline Linux kernel?
>
> PLEASE REVIEW: You added an mdelay(100) in plx_pci_check_sja1000() ...
+1 - Such a long delay should not end up in the common code.
> Are you sure this long delay is needed in plx_pci_check_sja1000() or should
> we better add a shorter mdelay(10) at the end of plx_pci_reset_common() ??
>
> Are you sure your setup is not working without the added mdelay(100) ?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2011-11-22 9:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 20:34 [RFC PATCH] plx_pci: add Advantech PCI-1680 & UNO-2052 support Oliver Hartkopp
2011-11-22 9:09 ` Marc Kleine-Budde [this message]
2011-11-24 20:35 ` Frantisek Rysanek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECB66D2.6030108@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=P.B.Cheblakov@inp.nsk.su \
--cc=linux-can@vger.kernel.org \
--cc=rysanek@fccps.cz \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.