Re: [PATCH 1/7] KVM: x86 emulator: Use opcode::execute for IN/OUT

[Avi Kivity <avi@redhat.com>]

On 11/22/2011 12:49 PM, Avi Kivity wrote:
> On 11/22/2011 08:16 AM, Takuya Yoshikawa wrote:
> > IN : E4, E5, EC, ED
> > OUT: E6, E7, EE, EF
> >
> > @@ -3867,11 +3888,12 @@ special_insn:
> >  	case 0x6c:		/* insb */
> >  	case 0x6d:		/* insw/insd */
> >  		ctxt->src.val = ctxt->regs[VCPU_REGS_RDX];
> > -		goto do_io_in;
> > +		rc = em_in(ctxt);
> > +		break;
> >  	case 0x6e:		/* outsb */
> >  	case 0x6f:		/* outsw/outsd */
> >  		ctxt->dst.val = ctxt->regs[VCPU_REGS_RDX];
> > -		goto do_io_out;
> > +		rc = em_out(ctxt);
> >  		break;
> >  	case 0x70 ... 0x7f: /* jcc (short) */
> >  		if (test_cc(ctxt->b, ctxt->eflags))
> >
>
> We have SrcDX/DstDX for these.
>

Everything else looks good; no need to regenerate this, it can be done
as a follow up patch if you like.

-- 
error compiling committee.c: too many arguments to function