All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, supriyak@linux.vnet.ibm.com,
	Luiz Capitulino <lcapitulino@redhat.com>,
	Christoph Hellwig <hch@lst.de>,
	supriya kannery <supriyak@in.ibm.com>
Subject: Re: [Qemu-devel] [v9 Patch 4/6]Qemu: Add commandline -drive option 'hostcache'
Date: Tue, 22 Nov 2011 12:31:01 +0100	[thread overview]
Message-ID: <4ECB87F5.1070908@redhat.com> (raw)
In-Reply-To: <CAJSP0QVSObHKt820LVpG8eZ+Nx2fL-cmOkWDPJnoBzEe-yfjEw@mail.gmail.com>

Am 22.11.2011 12:17, schrieb Stefan Hajnoczi:
> On Tue, Nov 22, 2011 at 9:55 AM, Kevin Wolf <kwolf@redhat.com> wrote:
>> Am 22.11.2011 09:10, schrieb supriya kannery:
>>> Let us have the implementation for hostcache= as command line option, with
>>> the condition that if both cache= and hostcache= are specified together,
>>> then depending upon enable/disable value specified for hostcache,
>>> corresponding
>>> bit in cache flags can be set/reset. That way, there is a value add on
>>> specifying
>>> hostcache in cmdline as well as user will be able to control hostcache
>>> value from cmdline
>>> itself.
>>
>> The additional thing this would introduce is cache=unsafe hostcache=off.
>> Probably not the most common thing to have, but why not allow it now.
> 
> QEMU's command-line is hairy enough already.  I don't think this
> option is helpful until we can replace cache= completely.
> 
> This is a subjective issue though so if you want to take this option,
> Kevin, then please do.

In fact, I think I suggested removing it in an earlier version of the
series because I felt the same. I didn't have a strong enough opinion on
it to really insist on it, though. Discuss it with Supriya and I'll be
happy with whatever you decide.

Kevin

  reply	other threads:[~2011-11-22 11:28 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-11  6:47 [Qemu-devel] [v9 Patch 0/6]Qemu: Host pagecache setting from cmdline and monitor Supriya Kannery
2011-11-11  6:47 ` [Qemu-devel] [v9 Patch 1/6]Qemu: Enhance "info block" to display host cache setting Supriya Kannery
2011-11-11 10:09   ` [Qemu-devel] [v9 Patch 1/6 - updated]Qemu: " Supriya Kannery
2011-11-17 12:38     ` Luiz Capitulino
2011-11-18  9:14       ` supriya kannery
2011-11-11  6:47 ` [Qemu-devel] [v9 Patch 2/6]Qemu: Error classes for file reopen and data sync failure Supriya Kannery
2011-11-17 12:50   ` Luiz Capitulino
2011-11-18  9:29     ` supriya kannery
2011-11-18 12:09       ` Luiz Capitulino
2011-11-11  6:47 ` [Qemu-devel] [v9 Patch 3/6]Qemu: Cmd "block_set_hostcache" for dynamic cache change Supriya Kannery
2011-11-16 18:34   ` Stefan Hajnoczi
2011-11-17  5:45     ` Supriya Kannery
2011-11-17 13:14       ` Luiz Capitulino
2011-11-17 13:11   ` Luiz Capitulino
2011-11-18 10:44     ` supriya kannery
2011-11-11  6:48 ` [Qemu-devel] [v9 Patch 4/6]Qemu: Add commandline -drive option 'hostcache' Supriya Kannery
2011-11-16 20:06   ` Stefan Hajnoczi
2011-11-17  5:18     ` Supriya Kannery
2011-11-17 14:11       ` Stefan Hajnoczi
2011-11-21 12:28         ` supriya kannery
2011-11-21 14:03           ` Stefan Hajnoczi
2011-11-22  8:10             ` supriya kannery
2011-11-22  9:55               ` Kevin Wolf
2011-11-22 11:17                 ` Stefan Hajnoczi
2011-11-22 11:31                   ` Kevin Wolf [this message]
2011-11-11  6:48 ` [Qemu-devel] [v9 Patch 5/6]Qemu: Framework for reopening images safely Supriya Kannery
2011-11-17 13:16   ` Luiz Capitulino
2011-11-17 14:36   ` Stefan Hajnoczi
2011-11-21 12:13     ` supriya kannery
2011-11-21 14:31       ` Stefan Hajnoczi
2011-11-22 10:24         ` supriya kannery
2011-11-22 11:04           ` Kevin Wolf
2011-11-22 11:16             ` supriya kannery
2011-11-22 11:49               ` Stefan Hajnoczi
2011-11-23  3:52                 ` Supriya Kannery
2011-11-11  6:48 ` [Qemu-devel] [v9 Patch 6/6]Qemu: raw posix implementation of reopen functions Supriya Kannery
2011-11-17 14:41   ` Stefan Hajnoczi
2011-11-21 12:30     ` supriya kannery
2011-11-22  9:45       ` supriya kannery
2011-11-22 11:32         ` Stefan Hajnoczi
2011-11-22 11:30           ` supriya kannery
2011-11-22 11:54             ` Stefan Hajnoczi
2011-11-22 11:36           ` Christoph Hellwig
2012-01-19 16:24 ` [Qemu-devel] [v9 Patch 0/6]Qemu: Host pagecache setting from cmdline and monitor Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ECB87F5.1070908@redhat.com \
    --to=kwolf@redhat.com \
    --cc=hch@lst.de \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=supriyak@in.ibm.com \
    --cc=supriyak@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.