All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1.0] configure: tighten pie toolchain support test for tls variables
Date: Tue, 22 Nov 2011 14:26:19 +0100	[thread overview]
Message-ID: <4ECBA2FB.9020705@redhat.com> (raw)
In-Reply-To: <1321965139-31265-1-git-send-email-avi@redhat.com>

On 11/22/11 13:32, Avi Kivity wrote:
> Some toolchains don't support pie properly when tls variables are
> in use.  Disallow pie when such toolchains are detected.
> 
> Signed-off-by: Avi Kivity <avi@redhat.com>
> ---
>  configure |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/configure b/configure
> index 75e1f10..7e6c640 100755
> --- a/configure
> +++ b/configure
> @@ -1120,7 +1120,10 @@ fi
>  
>  if test "$pie" != "no" ; then
>    cat > $TMPC << EOF
> -int main(void) { return 0; }
> +
> +static __thread tls_var;
> +
> +int main(void) { return tls_var; }
>  EOF
>    if compile_prog "-fPIE -DPIE" "-pie"; then
>      QEMU_CFLAGS="-fPIE -DPIE $QEMU_CFLAGS"

Survived testbuild.

thanks,
  Gerd

      reply	other threads:[~2011-11-22 13:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-22 12:32 [Qemu-devel] [PATCH 1.0] configure: tighten pie toolchain support test for tls variables Avi Kivity
2011-11-22 13:26 ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ECBA2FB.9020705@redhat.com \
    --to=kraxel@redhat.com \
    --cc=avi@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.