From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dataflash: fix parameters order in write_dataflash()
Date: Wed, 23 Nov 2011 11:23:30 +0200 [thread overview]
Message-ID: <4ECCBB92.60401@compulab.co.il> (raw)
In-Reply-To: <1320527563-4440-1-git-send-email-grinberg@compulab.co.il>
Hi all,
This is a trivial patch and it has been 18 days since posting it.
Can someone take care of it, please?
On 11/05/11 23:12, Igor Grinberg wrote:
> Fix parameters order in write_dataflash() function extern declaration in
> the header file.
> Parameters order, as in function definition, should be:
> addr_dest, addr_src, size.
>
> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
> ---
> include/dataflash.h | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/include/dataflash.h b/include/dataflash.h
> index 96ac097..094babb 100644
> --- a/include/dataflash.h
> +++ b/include/dataflash.h
> @@ -207,7 +207,8 @@ extern int addr2ram(ulong addr);
> extern int dataflash_real_protect (int flag, unsigned long start_addr, unsigned long end_addr);
> extern int addr_dataflash (unsigned long addr);
> extern int read_dataflash (unsigned long addr, unsigned long size, char *result);
> -extern int write_dataflash (unsigned long addr, unsigned long dest, unsigned long size);
> +extern int write_dataflash(unsigned long addr_dest, unsigned long addr_src,
> + unsigned long size);
> extern void dataflash_print_info (void);
> extern void dataflash_perror (int err);
> extern void AT91F_DataflashSetEnv (void);
--
Regards,
Igor.
next prev parent reply other threads:[~2011-11-23 9:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-05 21:12 [U-Boot] [PATCH] dataflash: fix parameters order in write_dataflash() Igor Grinberg
2011-11-23 9:23 ` Igor Grinberg [this message]
2011-11-27 9:06 ` [U-Boot] [PATCH v2] " Igor Grinberg
2011-11-27 19:01 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECCBB92.60401@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.