From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] ASoC: Constify snd_soc_dai_ops structs
Date: Wed, 23 Nov 2011 14:01:38 +0100 [thread overview]
Message-ID: <4ECCEEB2.6050407@metafoo.de> (raw)
In-Reply-To: <20111123104728.GL4332@opensource.wolfsonmicro.com>
On 11/23/2011 11:47 AM, Mark Brown wrote:
> On Wed, Nov 23, 2011 at 11:40:40AM +0100, Lars-Peter Clausen wrote:
>> Commit 1ee46ebd("ASoC: Make the DAI ops constant in the DAI structure")
>> introduced the possibility to have constant DAI ops structures, yet this is
>> barley used in both existing drivers and also new drivers being submitted,
>> although none of them modifies its DAI ops structure. The later is not
>> surprising since existing drivers are often used as templates for new drivers.
>> So this patch just constifies all existing snd_soc_dai_ops structs to eliminate
>> the issue altogether.
>
> Applied, thanks.
Argh, looks like I have to work a bit more on my coccinelle skills, I
introduced a few 'const const struct snd_soc_dai_ops' in this patch, which I
overlooked, since this seems to be legal C. Will send a followup cleanup patch.
next prev parent reply other threads:[~2011-11-23 13:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1322044840-32709-1-git-send-email-lars@metafoo.de>
2011-11-23 10:47 ` [PATCH] ASoC: Constify snd_soc_dai_ops structs Mark Brown
2011-11-23 13:01 ` Lars-Peter Clausen [this message]
2011-11-23 13:11 ` [PATCH] ASoC: Cleanup duplicated const Lars-Peter Clausen
2011-11-23 13:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECCEEB2.6050407@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.