From: Alexander Graf <agraf@suse.de>
To: Riku Voipio <riku.voipio@iki.fi>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] linux-user/strace.c: Correct errno printing for mmap etc
Date: Wed, 23 Nov 2011 14:18:56 +0100 [thread overview]
Message-ID: <4ECCF2C0.4010801@suse.de> (raw)
In-Reply-To: <20111123131525.GA11085@afflict.kos.to>
On 11/23/2011 02:15 PM, Riku Voipio wrote:
> On Mon, Nov 21, 2011 at 12:21:19PM +0000, Peter Maydell wrote:
>> Correct the printing of errnos for syscalls which are handled
>> via print_syscall_ret_addr (mmap, mmap2, brk, shmat): errnos
>> are returned as negative returned values at this level, not
>> via the host 'errno' variable.
>
>> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
>> ---
>> This applies on top of Alex's [v3] linux-user: fix QEMU_STRACE=1 segfault
>> patch. It is fixing a separate bug to that patch, but OTOH it does touch
>> only four lines of actual code, all of which were added in that patch.
>> Keep it separate or fold it in with that one, I don't mind.
> I think in general it is recommended to squash patches that only change lines
> added in the previous patch. Otoh it muddies the authorship of the change.
> Thus, unless someone objects, I'll que these as separate patches so both
> of you get clear credit.
I am completely indifferent :).
Alex
prev parent reply other threads:[~2011-11-23 13:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 12:21 [Qemu-devel] [PATCH] linux-user/strace.c: Correct errno printing for mmap etc Peter Maydell
2011-11-23 13:15 ` Riku Voipio
2011-11-23 13:18 ` Alexander Graf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECCF2C0.4010801@suse.de \
--to=agraf@suse.de \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.