From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RTG97-00007t-8j for qemu-devel@nongnu.org; Wed, 23 Nov 2011 11:58:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RTG92-00023i-VL for qemu-devel@nongnu.org; Wed, 23 Nov 2011 11:58:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:20730) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RTG92-00023d-Me for qemu-devel@nongnu.org; Wed, 23 Nov 2011 11:58:00 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pANGvxQ7018526 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 23 Nov 2011 11:57:59 -0500 Message-ID: <4ECD26D5.4040501@redhat.com> Date: Wed, 23 Nov 2011 18:01:09 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1321293318-19177-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1321293318-19177-1-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] qcow2: Unlock during COW List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org Am 14.11.2011 18:55, schrieb Kevin Wolf: > Unlocking during COW allows for more parallelism. One change it requires is > that buffers are dynamically allocated instead of just using a per-image > buffer. > > While touching the code, drop the synchronous qcow2_read() function and replace > it by a bdrv_read() call. > > Signed-off-by: Kevin Wolf This seems to break an IDE guest for me. I don't quite understand why yet, but maybe someone has an idea. hw/ide/pci.c:313: bmdma_cmd_writeb: Assertion `bm->bus->dma->aiocb == ((void *)0)' failed. Kevin