(unknown),

(unknown),

[Wido den Hollander]

When upgrading or installing we do not want to stop or start the init scripts.

This could break upgrades but also do harmfull stuff we don't want.

Let the sysadmin decide when to (re)start the daemons

[PATCH] debian init: Do not stop or start daemons when installing or upgrading

[Wido den Hollander]

Signed-off-by: Wido den Hollander <wido@widodh.nl>
---
 debian/rules |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/debian/rules b/debian/rules
index a20258d..4f3fe62 100755
--- a/debian/rules
+++ b/debian/rules
@@ -98,7 +98,7 @@ binary-arch: build install
 	dh_installexamples
 	dh_install --sourcedir=$(DESTDIR) --list-missing
 	dh_installlogrotate
-	dh_installinit
+	dh_installinit --no-start
 	dh_installman
 	dh_lintian
 	dh_link
-- 
1.7.5.4

Re: [PATCH] debian init: Do not stop or start daemons when installing or upgrading

[Sage Weil]

Ooh, that would certainly make things less annoying for me as well.  
Unless that's contrary to some debian policy/best practice, Laszlo?

sage


On Wed, 16 Nov 2011, Wido den Hollander wrote:

> 
> Signed-off-by: Wido den Hollander <wido@widodh.nl>
> ---
>  debian/rules |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/debian/rules b/debian/rules
> index a20258d..4f3fe62 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -98,7 +98,7 @@ binary-arch: build install
>  	dh_installexamples
>  	dh_install --sourcedir=$(DESTDIR) --list-missing
>  	dh_installlogrotate
> -	dh_installinit
> +	dh_installinit --no-start
>  	dh_installman
>  	dh_lintian
>  	dh_link
> -- 
> 1.7.5.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

Re: [PATCH] debian init: Do not stop or start daemons when installing or upgrading

[Wido den Hollander]

On 11/16/2011 08:53 PM, Sage Weil wrote:
> Ooh, that would certainly make things less annoying for me as well.
> Unless that's contrary to some debian policy/best practice, Laszlo?
>

We could also go for "--no-restart-on-upgrade".

I ran into this when upgrading the debs on my machines. The init script 
would try to stop any running radosgw processes, that failed (none were 
running), exited non-zero and that broke the prerm script.

But since we are dealing with potentially very important daemons I don't 
want any init scripts restarting my daemons, I want to do that myself.

Wido

> sage
>
>
> On Wed, 16 Nov 2011, Wido den Hollander wrote:
>
>>
>> Signed-off-by: Wido den Hollander<wido@widodh.nl>
>> ---
>>   debian/rules |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/debian/rules b/debian/rules
>> index a20258d..4f3fe62 100755
>> --- a/debian/rules
>> +++ b/debian/rules
>> @@ -98,7 +98,7 @@ binary-arch: build install
>>   	dh_installexamples
>>   	dh_install --sourcedir=$(DESTDIR) --list-missing
>>   	dh_installlogrotate
>> -	dh_installinit
>> +	dh_installinit --no-start
>>   	dh_installman
>>   	dh_lintian
>>   	dh_link
>> --
>> 1.7.5.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>>

Re: [PATCH] debian init: Do not stop or start daemons when installing or upgrading

[Wido den Hollander]

On 11/16/2011 08:53 PM, Sage Weil wrote:
> Ooh, that would certainly make things less annoying for me as well.
> Unless that's contrary to some debian policy/best practice, Laszlo?
>

Laszlo, have you been able to look at this yet?

Thanks!

Wido

> sage
>
>
> On Wed, 16 Nov 2011, Wido den Hollander wrote:
>
>>
>> Signed-off-by: Wido den Hollander<wido@widodh.nl>
>> ---
>>   debian/rules |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/debian/rules b/debian/rules
>> index a20258d..4f3fe62 100755
>> --- a/debian/rules
>> +++ b/debian/rules
>> @@ -98,7 +98,7 @@ binary-arch: build install
>>   	dh_installexamples
>>   	dh_install --sourcedir=$(DESTDIR) --list-missing
>>   	dh_installlogrotate
>> -	dh_installinit
>> +	dh_installinit --no-start
>>   	dh_installman
>>   	dh_lintian
>>   	dh_link
>> --
>> 1.7.5.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>>

Re: [PATCH] debian init: Do not stop or start daemons when installing or upgrading

[Laszlo Boszormenyi]

On Wed, 2011-11-23 at 20:59 +0100, Wido den Hollander wrote:
> On 11/16/2011 08:53 PM, Sage Weil wrote:
> > Ooh, that would certainly make things less annoying for me as well.
> > Unless that's contrary to some debian policy/best practice, Laszlo?
 Will check Debian policy. I think init scripts in other packages use a
variable in /etc/default/<package> like no_restart_on_upgrade .
On the other hand, I think init script may check if ceph is running or
not. If not, it should not start it. Leaving it running while ceph is
upgraded would be a bad idea. You would miss configuration file changes
and realize that it broke your node at random times when ceph is
restarted for any reason.

> Laszlo, have you been able to look at this yet?
 Ouch, haven't seen this thread yet. Hope that I can answer in detail
soon.

Laszlo/GCS

Re: [PATCH] debian init: Do not stop or start daemons when installing or upgrading

[Laszlo Boszormenyi]

On Wed, 2011-11-16 at 11:53 -0800, Sage Weil wrote:
> Ooh, that would certainly make things less annoying for me as well.  
> Unless that's contrary to some debian policy/best practice, Laszlo?
 The following change is fine with me. Please commit it sage and I'll do
the same in the next upload.

> On Wed, 16 Nov 2011, Wido den Hollander wrote:
> > diff --git a/debian/rules b/debian/rules
> > index a20258d..4f3fe62 100755
> > --- a/debian/rules
> > +++ b/debian/rules
> > @@ -98,7 +98,7 @@ binary-arch: build install
> >  	dh_installexamples
> >  	dh_install --sourcedir=$(DESTDIR) --list-missing
> >  	dh_installlogrotate
> > -	dh_installinit
> > +	dh_installinit --no-start
> >  	dh_installman
> >  	dh_lintian
> >  	dh_link

Regards,
Laszlo/GCS

Re: [PATCH] debian init: Do not stop or start daemons when installing or upgrading

[Sage Weil]

Applied.

On Wed, 16 Nov 2011, Wido den Hollander wrote:

> 
> Signed-off-by: Wido den Hollander <wido@widodh.nl>
> ---
>  debian/rules |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/debian/rules b/debian/rules
> index a20258d..4f3fe62 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -98,7 +98,7 @@ binary-arch: build install
>  	dh_installexamples
>  	dh_install --sourcedir=$(DESTDIR) --list-missing
>  	dh_installlogrotate
> -	dh_installinit
> +	dh_installinit --no-start
>  	dh_installman
>  	dh_lintian
>  	dh_link
> -- 
> 1.7.5.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
>