From: Gabor Juhos <juhosg@openwrt.org>
To: "René Bolldorf" <xsecute@googlemail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, Imre Kaloz <kaloz@openwrt.org>
Subject: Re: [PATCH 00/12] MIPS: ath79: AR724X PCI fixes and AR71XX PCI support
Date: Wed, 23 Nov 2011 21:39:32 +0100 [thread overview]
Message-ID: <4ECD5A04.1020702@openwrt.org> (raw)
In-Reply-To: <CAEWqx5_hgSH0FoWJPL0JDrVXGTWFCV0-FH9hXPMTxbG3A1pScQ@mail.gmail.com>
Hi,
<...>
>> I'm curious why do you think that it is broken now.
>> You are getting a data bus error by any chance?
>>
>
> after a pci write, the pci read return bogus values.
Can you be more specific please? The new code reads bogus values from every
configuration registers or only from some of them?
> However, I go through this tomorrow.
Ok.
<...>
>>> -I never hit the pci controller bug, any steps to replicate?
>>
>> Hm, weird. Your devices are based on AR7240 or or AR7241?
>>
>> Regards,
>> Gabor
>>
>
> AR7241 AH-4A
Yeah, that is different, my Bullet 5M uses an AR7240. I have retested the code
with and without the workaround on an AR7241 based board and it is working in
both cases. So it seems that the AR7241 is not affected. I will change the patch
to use the workaround only if the kernel is running on AR7240.
> Maybe it is better to split ar71xx and ar72xx pci support completly?
Sorry, what do you mean? It is separated already. The common functions are
'pcibios_map_irq', 'pcibios_plat_dev_init' and 'ath79_register_pci'. None of
these functions are related to accessing of the PCI devices. Additionally, the
'ath79_register_pci' function calls the appropriate 'ar7{1x,24}x_pcibios_init'
depending on the actual SoC, so the AR71XX specific PCI controller code never
runs on AR724X.
-Gabor
prev parent reply other threads:[~2011-11-23 20:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 23:14 [PATCH 00/12] MIPS: ath79: AR724X PCI fixes and AR71XX PCI support Gabor Juhos
2011-11-22 23:14 ` [PATCH 01/12] MIPS: ath79: remove superfluous alignment checks from pci-ar724x.c Gabor Juhos
2011-11-22 23:14 ` [PATCH 02/12] MIPS: ath79: fix broken ar724x_pci_{read,write} functions Gabor Juhos
2011-11-22 23:14 ` [PATCH 03/12] MIPS: ath79: add a workaround for a PCI controller bug in AR724X SoCs Gabor Juhos
2011-11-22 23:14 ` [PATCH 04/12] MIPS: ath79: fix a wrong IRQ number Gabor Juhos
2011-11-22 23:14 ` [PATCH 05/12] MIPS: ath79: add PCI IRQ handling code for AR724X SoCs Gabor Juhos
2011-11-22 23:14 ` [PATCH 06/12] MIPS: ath79: get rid of some ifdefs in mach-ubnt-xm.c Gabor Juhos
2011-11-22 23:14 ` [PATCH 07/12] MIPS: ath79: allow to use board specific pci_plat_dev_init functions Gabor Juhos
2011-11-22 23:14 ` [PATCH 08/12] MIPS: ath79: add support for the PCI host controller of the AR71XX SoCs Gabor Juhos
2011-11-23 9:21 ` Sergei Shtylyov
2011-11-23 12:04 ` Gabor Juhos
2011-11-22 23:14 ` [PATCH 09/12] MIPS: ath79: allow to use SoC specific PCI IRQ maps Gabor Juhos
2011-11-22 23:14 ` [PATCH 10/12] MIPS: ath79: remove ar724x_pci_add_data function Gabor Juhos
2011-11-22 23:14 ` [PATCH 11/12] MIPS: ath79: register PCI controller on the PB44 board Gabor Juhos
2011-11-22 23:14 ` [PATCH 12/12] MIPS: ath79: update copyright headers of PCI related files Gabor Juhos
2011-11-23 11:35 ` [PATCH 00/12] MIPS: ath79: AR724X PCI fixes and AR71XX PCI support René Bolldorf
2011-11-23 14:08 ` Gabor Juhos
2011-11-23 14:40 ` René Bolldorf
2011-11-23 15:15 ` René Bolldorf
2011-11-23 20:43 ` Gabor Juhos
2011-11-24 10:37 ` René Bolldorf
2011-11-24 15:06 ` Gabor Juhos
2011-11-24 15:54 ` René Bolldorf
2011-11-24 18:39 ` Gabor Juhos
2011-11-23 20:39 ` Gabor Juhos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECD5A04.1020702@openwrt.org \
--to=juhosg@openwrt.org \
--cc=kaloz@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=xsecute@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.