From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta12.messagelabs.com (mail6.bemta12.messagelabs.com [216.82.250.247]) by kanga.kvack.org (Postfix) with ESMTP id 08C676B0075 for ; Wed, 23 Nov 2011 20:27:32 -0500 (EST) Message-ID: <4ECD9D43.6090202@cn.fujitsu.com> Date: Thu, 24 Nov 2011 09:26:27 +0800 From: Miao Xie Reply-To: miaox@cn.fujitsu.com MIME-Version: 1.0 Subject: Re: [patch for-3.2-rc3] cpusets: stall when updating mems_allowed for mempolicy or disjoint nodemask References: <4EC4C603.8050704@cn.fujitsu.com> <4EC62AEA.2030602@cn.fujitsu.com> <4ECC5FC8.9070500@cn.fujitsu.com> <4ECC7B1E.6020108@cn.fujitsu.com> <4ECCA578.6020700@cn.fujitsu.com> In-Reply-To: Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes Cc: Andrew Morton , Linus Torvalds , KOSAKI Motohiro , Paul Menage , linux-kernel@vger.kernel.org, linux-mm@kvack.org On Wed, 23 Nov 2011 14:26:40 -0800 (pst), David Rientjes wrote: > On Wed, 23 Nov 2011, Miao Xie wrote: > >> That nodemask is also protected by get_mems_allowed(). >> > > So what's the problem with the patch? Memory compaction will see an empty nodemask and do nothing, and then we may fail to get several contiguous pages. > Can I add your acked-by? Sure, no problem. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753153Ab1KXB1Z (ORCPT ); Wed, 23 Nov 2011 20:27:25 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:60414 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752070Ab1KXB1Y (ORCPT ); Wed, 23 Nov 2011 20:27:24 -0500 Message-ID: <4ECD9D43.6090202@cn.fujitsu.com> Date: Thu, 24 Nov 2011 09:26:27 +0800 From: Miao Xie Reply-To: miaox@cn.fujitsu.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 MIME-Version: 1.0 To: David Rientjes CC: Andrew Morton , Linus Torvalds , KOSAKI Motohiro , Paul Menage , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch for-3.2-rc3] cpusets: stall when updating mems_allowed for mempolicy or disjoint nodemask References: <4EC4C603.8050704@cn.fujitsu.com> <4EC62AEA.2030602@cn.fujitsu.com> <4ECC5FC8.9070500@cn.fujitsu.com> <4ECC7B1E.6020108@cn.fujitsu.com> <4ECCA578.6020700@cn.fujitsu.com> In-Reply-To: X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2011-11-24 09:27:07, Serialize by Router on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2011-11-24 09:27:08, Serialize complete at 2011-11-24 09:27:08 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 23 Nov 2011 14:26:40 -0800 (pst), David Rientjes wrote: > On Wed, 23 Nov 2011, Miao Xie wrote: > >> That nodemask is also protected by get_mems_allowed(). >> > > So what's the problem with the patch? Memory compaction will see an empty nodemask and do nothing, and then we may fail to get several contiguous pages. > Can I add your acked-by? Sure, no problem.