From: Koki Sanagi <sanagi.koki@jp.fujitsu.com>
To: netdev@vger.kernel.org, jeffrey.t.kirsher@intel.com,
jesse.brandeburg@intel.com, bruce.w.allan@intel.com,
carolyn.wyborny@intel.com, donald.c.skidmore@intel.com,
gregory.v.rose@intel.com, peter.p.waskiewicz.jr@intel.com,
alexander.h.duyck@intel.com, john.ronciak@intel.com,
e1000-devel@lists.sourceforge.net
Cc: davem@davemloft.net
Subject: [PATCH net-next] igb: reset PHY after recovering from PHY power down
Date: Thu, 24 Nov 2011 12:18:07 +0900 [thread overview]
Message-ID: <4ECDB76F.1090104@jp.fujitsu.com> (raw)
According to 82576_Datasheet.pdf, PHY setting is lost after PHY power down.
So resetting PHY is needed when recovering from PHY power down to set a default
setting to PHY register.
Owing to this lack, NIC doesn't link up in some rare situation.
The situation I encountered is following.
1.Both ports connect to switch.
+---------+ +--------+
| |-----------| |
| 82576NS | | switch |
| |-----------| |
+---------+ +--------+
2.Detach both cables from switch.
+---------+ +--------+
| |------- | |
| 82576NS | | switch |
| |------- | |
+---------+ +--------+
3.Detach one cable from one port.
+---------+ +--------+
| |------- | |
| 82576NS | | switch |
| | | |
+---------+ +--------+
4.Attach that cable to the other port.(It means connecting directly each port)
+---------+ +--------+
| |-------+ | |
| 82576NS | | | switch |
| |-------+ | |
+---------+ +--------+
As a result, NIC doesn't link up sometimes.
Signed-off-by: Koki Sanagi <sanagi.koki@jp.fujitsu.com>
---
drivers/net/ethernet/intel/igb/igb_main.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index bd9b30e..4d4f065 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -2496,6 +2496,7 @@ static int igb_open(struct net_device *netdev)
goto err_setup_rx;
igb_power_up_link(adapter);
+ igb_reset_phy(hw);
/* before we allocate an interrupt, we must be ready to handle it.
* Setting DEBUG_SHIRQ in the kernel makes it fire an interrupt
next reply other threads:[~2011-11-24 3:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 3:18 Koki Sanagi [this message]
2011-11-28 17:57 ` [PATCH net-next] igb: reset PHY after recovering from PHY power down Wyborny, Carolyn
2011-12-14 5:55 ` Koki Sanagi
2011-12-16 15:53 ` Wyborny, Carolyn
2011-12-18 23:59 ` Koki Sanagi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECDB76F.1090104@jp.fujitsu.com \
--to=sanagi.koki@jp.fujitsu.com \
--cc=alexander.h.duyck@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=gregory.v.rose@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.