diff for duplicates of <4ECE083D.4030707@bfs.de> diff --git a/a/1.txt b/N1/1.txt index b9dd2c8..4be160c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -20,7 +20,7 @@ Am 24.11.2011 08:21, schrieb Dan Carpenter: > - ret = 0; > for (floor = 0; floor < DOC_MAX_NBFLOORS; floor++) { > mtd = doc_probe_device(base, floor, dev); -> - if (floor = 0 && !mtd) +> - if (floor == 0 && !mtd) > - goto notfound; > - if (!IS_ERR_OR_NULL(mtd)) > - ret = mtd_device_parse_register(mtd, part_probes, @@ -31,7 +31,7 @@ Am 24.11.2011 08:21, schrieb Dan Carpenter: > + goto err_probe; > + } > + if (!mtd) { -> + if (floor = 0) +> + if (floor == 0) > + goto notfound; > + else > + continue; @@ -39,7 +39,7 @@ Am 24.11.2011 08:21, schrieb Dan Carpenter: > docg3_floors[floor] = mtd; > + ret = mtd_device_parse_register(mtd, part_probes, NULL, NULL, > + - the code nicely shows that docg3_floors[floor] will be foobar if mtd=NULL and floor > 0 + the code nicely shows that docg3_floors[floor] will be foobar if mtd==NULL and floor > 0 I guess that can cause problems with the "doc_release_device(docg3_floors[floor]);" perhaps a "docg3_floors[floor] = NULL;" can help here ? diff --git a/a/content_digest b/N1/content_digest index 72c7a80..d1da2bb 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020111124072117.GC14122@elgon.mountain\0" "From\0walter harms <wharms@bfs.de>\0" "Subject\0Re: [patch] mtd/docg3: fix error handling in docg3_probe()\0" - "Date\0Thu, 24 Nov 2011 09:02:53 +0000\0" + "Date\0Thu, 24 Nov 2011 10:02:53 +0100\0" "To\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Cc\0Robert Jarzmik <robert.jarzmik@free.fr>" kernel-janitors@vger.kernel.org @@ -31,7 +31,7 @@ "> -\tret = 0;\n" "> \tfor (floor = 0; floor < DOC_MAX_NBFLOORS; floor++) {\n" "> \t\tmtd = doc_probe_device(base, floor, dev);\n" - "> -\t\tif (floor = 0 && !mtd)\n" + "> -\t\tif (floor == 0 && !mtd)\n" "> -\t\t\tgoto notfound;\n" "> -\t\tif (!IS_ERR_OR_NULL(mtd))\n" "> -\t\t\tret = mtd_device_parse_register(mtd, part_probes,\n" @@ -42,7 +42,7 @@ "> +\t\t\tgoto err_probe;\n" "> +\t\t}\n" "> +\t\tif (!mtd) {\n" - "> +\t\t\tif (floor = 0)\n" + "> +\t\t\tif (floor == 0)\n" "> +\t\t\t\tgoto notfound;\n" "> +\t\t\telse\n" "> +\t\t\t\tcontinue;\n" @@ -50,7 +50,7 @@ "> \t\tdocg3_floors[floor] = mtd;\n" "> +\t\tret = mtd_device_parse_register(mtd, part_probes, NULL, NULL,\n" "> +\t\t\n" - "\tthe code nicely shows that docg3_floors[floor] will be foobar if mtd=NULL and floor > 0\n" + "\tthe code nicely shows that docg3_floors[floor] will be foobar if mtd==NULL and floor > 0\n" "\tI guess that can cause problems with the \"doc_release_device(docg3_floors[floor]);\"\n" "\t\n" "\tperhaps a \"docg3_floors[floor] = NULL;\" can help here ?\n" @@ -86,4 +86,4 @@ "> \n" > -a4f527f7bbf239be89e5ace87d1a79fb381752831932531eee6af25f31042b4b +b1803069a9a2c3d5511780b2156254a66d3a76000ec6aaf4bcba116d1ad1c3a4
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.