From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Wolfgang Grandegger <wg@grandegger.com>
Cc: Netdev@vger.kernel.org,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Subject: Re: [PATCH] can: sja1000_isa: fix "limited range" compiler warnings
Date: Thu, 24 Nov 2011 10:34:46 +0100 [thread overview]
Message-ID: <4ECE0FB6.5000106@pengutronix.de> (raw)
In-Reply-To: <4ECE0993.6050902@grandegger.com>
[-- Attachment #1: Type: text/plain, Size: 2851 bytes --]
On 11/24/2011 10:08 AM, Wolfgang Grandegger wrote:
> This patch fixes the compiler warnings: "comparison is always
> false due to limited range of data type" by using "0xff" instead
> of "-1" for unsigned values.
>
> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
> drivers/net/can/sja1000/sja1000_isa.c | 24 ++++++++++++------------
> 1 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/net/can/sja1000/sja1000_isa.c b/drivers/net/can/sja1000/sja1000_isa.c
> index 496223e..f0840d5 100644
> --- a/drivers/net/can/sja1000/sja1000_isa.c
> +++ b/drivers/net/can/sja1000/sja1000_isa.c
> @@ -44,9 +44,9 @@ static unsigned long port[MAXDEV];
> static unsigned long mem[MAXDEV];
> static int __devinitdata irq[MAXDEV];
> static int __devinitdata clk[MAXDEV];
> -static char __devinitdata cdr[MAXDEV] = {[0 ... (MAXDEV - 1)] = -1};
> -static char __devinitdata ocr[MAXDEV] = {[0 ... (MAXDEV - 1)] = -1};
> -static char __devinitdata indirect[MAXDEV] = {[0 ... (MAXDEV - 1)] = -1};
> +static unsigned char __devinitdata cdr[MAXDEV] = {[0 ... (MAXDEV - 1)] = 0xff};
> +static unsigned char __devinitdata ocr[MAXDEV] = {[0 ... (MAXDEV - 1)] = 0xff};
> +static int __devinitdata indirect[MAXDEV] = {[0 ... (MAXDEV - 1)] = -1};
>
> module_param_array(port, ulong, NULL, S_IRUGO);
> MODULE_PARM_DESC(port, "I/O port number");
> @@ -54,7 +54,7 @@ MODULE_PARM_DESC(port, "I/O port number");
> module_param_array(mem, ulong, NULL, S_IRUGO);
> MODULE_PARM_DESC(mem, "I/O memory address");
>
> -module_param_array(indirect, byte, NULL, S_IRUGO);
> +module_param_array(indirect, int, NULL, S_IRUGO);
> MODULE_PARM_DESC(indirect, "Indirect access via address and data port");
>
> module_param_array(irq, int, NULL, S_IRUGO);
> @@ -189,17 +189,17 @@ static int __devinit sja1000_isa_probe(struct device *pdev, unsigned int idx)
> else
> priv->can.clock.freq = CLK_DEFAULT / 2;
>
> - if (ocr[idx] != -1)
> - priv->ocr = ocr[idx] & 0xff;
> - else if (ocr[0] != -1)
> - priv->ocr = ocr[0] & 0xff;
> + if (ocr[idx] != 0xff)
> + priv->ocr = ocr[idx];
> + else if (ocr[0] != 0xff)
> + priv->ocr = ocr[0];
> else
> priv->ocr = OCR_DEFAULT;
>
> - if (cdr[idx] != -1)
> - priv->cdr = cdr[idx] & 0xff;
> - else if (cdr[0] != -1)
> - priv->cdr = cdr[0] & 0xff;
> + if (cdr[idx] != 0xff)
> + priv->cdr = cdr[idx];
> + else if (cdr[0] != 0xff)
> + priv->cdr = cdr[0];
> else
> priv->cdr = CDR_DEFAULT;
>
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2011-11-24 9:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 9:08 [PATCH] can: sja1000_isa: fix "limited range" compiler warnings Wolfgang Grandegger
2011-11-24 9:34 ` Marc Kleine-Budde [this message]
2011-11-29 23:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECE0FB6.5000106@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=Netdev@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.