All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Jamie Iles <jamie@jamieiles.com>
Cc: netdev@vger.kernel.org,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Subject: Re: [PATCH] macb: convert platform data phy_irq_pin to an int
Date: Thu, 24 Nov 2011 11:47:50 +0100	[thread overview]
Message-ID: <4ECE20D6.1080409@atmel.com> (raw)
In-Reply-To: <1322128098-17724-1-git-send-email-jamie@jamieiles.com>

On 11/24/2011 10:48 AM, Jamie Iles :
> AT91 platforms have been updated to set the phy_irq_pin to -EINVAL if
> not present, but phy_irq_pin is currently a u8.
> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

> Signed-off-by: Jamie Iles <jamie@jamieiles.com>
> ---
>  include/linux/platform_data/macb.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/platform_data/macb.h b/include/linux/platform_data/macb.h
> index e7c748f..b081c72 100644
> --- a/include/linux/platform_data/macb.h
> +++ b/include/linux/platform_data/macb.h
> @@ -10,7 +10,7 @@
>  
>  struct macb_platform_data {
>  	u32		phy_mask;
> -	u8		phy_irq_pin;	/* PHY IRQ */
> +	int		phy_irq_pin;	/* PHY IRQ */
>  	u8		is_rmii;	/* using RMII interface? */
>  };
>  


-- 
Nicolas Ferre

  reply	other threads:[~2011-11-24 10:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-24  9:48 [PATCH] macb: convert platform data phy_irq_pin to an int Jamie Iles
2011-11-24 10:47 ` Nicolas Ferre [this message]
2011-11-24 21:21 ` [PATCH] at91_ether: use gpio_is_valid for phy IRQ line Nicolas Ferre
2011-11-24 21:21   ` Nicolas Ferre
2011-11-24 22:28   ` Jamie Iles
2011-11-24 22:28     ` Jamie Iles
2011-11-25 13:47     ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-25 13:47       ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-25 13:56       ` Nicolas Ferre
2011-11-25 13:56         ` Nicolas Ferre
2011-11-29 23:53   ` David Miller
2011-11-29 23:53     ` David Miller
2011-11-30  4:44     ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-30  4:44       ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-30  5:40       ` David Miller
2011-11-30  5:40         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ECE20D6.1080409@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=jamie@jamieiles.com \
    --cc=netdev@vger.kernel.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.