From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RTZb6-000243-Ii for qemu-devel@nongnu.org; Thu, 24 Nov 2011 08:44:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RTZb5-0007CF-FD for qemu-devel@nongnu.org; Thu, 24 Nov 2011 08:44:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RTZb5-0007C7-7m for qemu-devel@nongnu.org; Thu, 24 Nov 2011 08:44:15 -0500 Message-ID: <4ECE4A2B.1010402@redhat.com> Date: Thu, 24 Nov 2011 15:44:11 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1322141482-12173-1-git-send-email-benoit.canet@gmail.com> In-Reply-To: <1322141482-12173-1-git-send-email-benoit.canet@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 00/11] more memory API conversions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: qemu-devel@nongnu.org On 11/24/2011 03:31 PM, Beno=C3=AEt Canet wrote: > These patches convert some files to memory API > > I am wondering if the bonito ones are corrects as > sysbus_mmio_map() use internally get_system_memory(). >>From a "will it work" perspective, I think it's correct since it system_memory is supposed to be equivalent to cpu_register_physical_memory(). >>From an "is this the right thing", well, we'll need to hack up sysbus not to call get_system_memory() itself, but that's an unrelated problem. > v2: > remove unneeded casts in mcf_uart > remove unneeded #include in lm32_uart and lm32_sys > > v3: > use valid.accept in lm32_sys > > v4: > bonito: use the pci_host sysbus pointer > bonito: use pci_host->conf_mem and pci_host->data_mem > Looks good to me. I'll apply next week to allow people to review. --=20 error compiling committee.c: too many arguments to function