All of lore.kernel.org
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@linux.intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] bitbake.conf: Set BB_CONSOLELOG so we log console messages by default
Date: Thu, 24 Nov 2011 08:13:32 -0800	[thread overview]
Message-ID: <4ECE6D2C.1000704@linux.intel.com> (raw)
In-Reply-To: <1322146689.10818.1.camel@ted>

I believe this is the fix for Yocto Bug 1771? If so, awesome! A one
liner, something to be said for really knowing the codebase.

I would only suggest a commit log which includes the bug line,
motivation and the approach taken, per the contribution guidelines.
Maybe something like:

"""""
Fixes [YOCTO #1771]

The console log is often helpful for debugging issues. Difficult to
reproduce bugs would benefit from a log being generated by default as it
may be difficult to come by after the fact. Log to
tmp/cooker.log.${DATETIME} by default.
"""""

Thanks,

Darren


On 11/24/2011 06:58 AM, Richard Purdie wrote:
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 01f064c..4589909 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -732,6 +732,8 @@ DISTRO[unexport] = "1"
>  # Used by canadian-cross to handle string conversions on TARGET_ARCH where needed
>  TRANSLATED_TARGET_ARCH ??= "${@d.getVar('TARGET_ARCH', True).replace("_", "-")}"
>  
> +BB_CONSOLELOG = "${TMPDIR}/cooker.log.${DATETIME}"
> +
>  # Setup our default hash policy
>  BB_SIGNATURE_HANDLER ?= "basic"
>  BB_HASHTASK_WHITELIST ?= "(.*-cross$|.*-native$|.*-cross-initial$|.*-cross-intermediate$|^virtual:native:.*|^virtual:nativesdk:.*)"
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel



  reply	other threads:[~2011-11-24 16:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-24 14:58 [PATCH] bitbake.conf: Set BB_CONSOLELOG so we log console messages by default Richard Purdie
2011-11-24 16:13 ` Darren Hart [this message]
2011-11-24 16:22   ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ECE6D2C.1000704@linux.intel.com \
    --to=dvhart@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.