Re: [RFCv2 PATCH 12/12] Remove audio.h, video.h and osd.h.

[Andreas Oberritter <obi@linuxtv.org>]

On 24.11.2011 18:44, Hans Verkuil wrote:
> On Thursday, November 24, 2011 18:08:05 Andreas Oberritter wrote:
>> Don't break existing Userspace APIs for no reason! It's OK to add the
>> new API, but - pretty please - don't just blindly remove audio.h and
>> video.h. They are in use since many years by av7110, out-of-tree drivers
>> *and more importantly* by applications. Yes, I know, you'd like to see
>> those out-of-tree drivers merged, but it isn't possible for many
>> reasons. And even if they were merged, you'd say "Port them and your
>> apps to V4L". No! That's not an option.
> 
> I'm not breaking anything. All apps will still work.
> 
> One option (and it depends on whether people like it or not) is to have
> audio.h, video.h and osd.h just include av7110.h and add a #warning
> that these headers need to be replaced by the new av7110.h.
> 
> And really remove them at some point in the future.
> 
> But the important thing to realize is that the ABI hasn't changed (unless
> I made a mistake somewhere).

So why don't you just leave the headers where they are and add a notice
about the new V4L API as a comment?

What you proposed breaks compilation. If you add a warning, it breaks
compilation for programs compiled with -Werror. Both are regressions.

Regards,
Andreas