From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RTflx-0003Hc-GZ for qemu-devel@nongnu.org; Thu, 24 Nov 2011 15:19:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RTflw-0002D9-ET for qemu-devel@nongnu.org; Thu, 24 Nov 2011 15:19:53 -0500 Received: from cantor2.suse.de ([195.135.220.15]:57944 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RTflw-0002Ca-4X for qemu-devel@nongnu.org; Thu, 24 Nov 2011 15:19:52 -0500 Message-ID: <4ECEA6C5.2030707@suse.de> Date: Thu, 24 Nov 2011 21:19:17 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Peter Chubb , qemu-devel@nongnu.org Am 24.11.2011 20:41, schrieb Peter Maydell: > On 22 November 2011 04:34, Peter Chubb wrote= : >> +obj-arm-y +=3D imx_serial.o imx_timer.o imx_avic.o >> +obj-arm-y +=3D kzm.o >=20 > It would be better to add the devices to the makefile in their > corresponding patches, I think. (Don't feel too strongly about that > though so somebody might overrule me.) Well, I do: Without adding them to the Makefile they don't get compile-tested. (I prefer convincing over ruling though.) Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg