From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:51866)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RTh8P-0006XR-Ax
	for qemu-devel@nongnu.org; Thu, 24 Nov 2011 16:47:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RTh8O-0007pV-A3
	for qemu-devel@nongnu.org; Thu, 24 Nov 2011 16:47:09 -0500
Received: from cantor2.suse.de ([195.135.220.15]:34890 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RTh8O-0007pR-5T
	for qemu-devel@nongnu.org; Thu, 24 Nov 2011 16:47:08 -0500
Message-ID: <4ECEBB34.4070509@suse.de>
Date: Thu, 24 Nov 2011 22:46:28 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <w4y5x8yt37.wl%peter@chubb.wattle.id.au>
	<CAFEAcA-4Kp_BWMzfd7AryuEF7CjWwGdQO6gtVv8wCMVbD1tU3g@mail.gmail.com>
	<w4y5x6g8gk.wl%peter@chubb.wattle.id.au>
	<CAFEAcA8-iByH0xgjkMUo3hvkrLc8NV-Lq4GbHU-d7UoF8GSX-Q@mail.gmail.com>
	<w4lir9m931.wl%peter@chubb.wattle.id.au>
	<CAFEAcA9YwTfAJ98LzDpJPADqoAVByn==Hgw=skm8OurFD_iCxg@mail.gmail.com>
	<w47h2sbwwt.wl%peter@chubb.wattle.id.au>
	<w41ut0bwr3.wl%peter@chubb.wattle.id.au>
	<CAFEAcA9TKAXL+pBD4duFgMKfYdhw=C=ru8juN4VTqLUO6qBkfQ@mail.gmail.com>
	<4ECEA6C5.2030707@suse.de>
	<CAFEAcA-hcAOM3-apPNqxOfuApeFSaD3cFVbArqwifiQQhTcLAg@mail.gmail.com>
In-Reply-To: <CAFEAcA-hcAOM3-apPNqxOfuApeFSaD3cFVbArqwifiQQhTcLAg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support:
 Makefile and board
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Peter Chubb <peter.chubb@nicta.com.au>, qemu-devel@nongnu.org

Am 24.11.2011 22:31, schrieb Peter Maydell:
> On 24 November 2011 20:19, Andreas F=C3=A4rber <afaerber@suse.de> wrote=
:
>> Am 24.11.2011 20:41, schrieb Peter Maydell:
>>> On 22 November 2011 04:34, Peter Chubb <peter.chubb@nicta.com.au> wro=
te:
>>>> +obj-arm-y +=3D imx_serial.o imx_timer.o imx_avic.o
>>>> +obj-arm-y +=3D kzm.o
>>>
>>> It would be better to add the devices to the makefile in their
>>> corresponding patches, I think. (Don't feel too strongly about that
>>> though so somebody might overrule me.)
>>
>> Well, I do: Without adding them to the Makefile they don't get
>> compile-tested. (I prefer convincing over ruling though.)
>=20
> Er, which way are you arguing? If patch 1 adds hw/foo.c and also
> adds foo.o to the makefile rune then it gets compile tested...

I'm asking for Peter C. to revise the series, please.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg