Re: [RFC/PATCH 0/3] 64-bit integer menus

[Sylwester Nawrocki <snjw23@gmail.com>]

Hi Sakari,

thanks for the patches.

On 11/24/2011 05:12 PM, Sakari Ailus wrote:
> Hi all,
> 
> This patchset, which I'm sending as RFC since it has not been really tested
> (including compiling the vivi patch), adds 64-bit integer menu controls. The
> control items in the integer menu are just like in regular menus but they
> are 64-bit integers instead of strings.
> 
> I'm also pondering whether to assign 1 to ctrl->step for menu type controls
> as well but haven't checked what may have been the original reason to
> implement it as it is now implemented.
> 
> The reason why I don't use a union for qmenu and qmenu_int in
> v4l2_ctrl_config is that a lot of drivers use that field in the initialiser
> and GCC<  4.6 does not support initialisers with anonymous unions.
> 
> Similar union is created in v4l2_querymenu but I do not see this as a
> problem since I do not expect initialisers to be used with this field in the
> user space code.
> 
> Comments and questions are welcome.

I've gone briefly through the patches and they seem to realize exactly what
I needed. I think we've discussed the integer menu controls during the Cambourne 
meeting, however I wasn't sure yesterday if it was just this.

I'll try and implement some of the controls for m5mols based on your patches.
Cannot guarantee I'll manage to have something ready for 3.3, I need to finish 
a few other things before I get to this. 

-- 
Thanks,
Sylwester