From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1RTsbK-0001ot-U2 for kexec@lists.infradead.org; Fri, 25 Nov 2011 10:01:48 +0000 Message-ID: <4ECF680C.7060606@redhat.com> Date: Fri, 25 Nov 2011 18:03:56 +0800 From: Dave Young MIME-Version: 1.0 Subject: Re: [PATCH] kexec: do not call kmsg_dump in crashdump References: <20111125081959.GA2505@darkstar.nay.redhat.com> In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Cong Wang Cc: kexec@lists.infradead.org, ebiederm@xmission.com, linux-kernel@vger.kernel.org On 11/25/2011 05:32 PM, Cong Wang wrote: > On Fri, Nov 25, 2011 at 4:19 PM, Dave Young wrote: >> mtd/ram oops dumper will make more functions envolved. In case crash kexec, >> we should avoid kmsg dumper to ensure crashdump success. >> >> kill kmsg_dump callback while crash dumping > > https://lkml.org/lkml/2011/2/1/33 Thanks for give the link. So it's intend to be that. I'm still confused with the KMSG_DUMP_KEXEC. crash_kexec() kmsg_dump(KMSG_DUMP_KEXEC) kmsg_dump(KMSG_DUMP_PANIC) Looks like it's equal to original logic, isn't it? kmsg_dump(anything); crash_kexec() So why intruduce KMSG_DUMP_KEXEC? why not just kmsg_dump before crash_kexec? thoughts? -- Thanks Dave _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753745Ab1KYKBt (ORCPT ); Fri, 25 Nov 2011 05:01:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57094 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752571Ab1KYKBs (ORCPT ); Fri, 25 Nov 2011 05:01:48 -0500 Message-ID: <4ECF680C.7060606@redhat.com> Date: Fri, 25 Nov 2011 18:03:56 +0800 From: Dave Young User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110323 Thunderbird/3.1.9 MIME-Version: 1.0 To: Cong Wang CC: ebiederm@xmission.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kexec: do not call kmsg_dump in crashdump References: <20111125081959.GA2505@darkstar.nay.redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/25/2011 05:32 PM, Cong Wang wrote: > On Fri, Nov 25, 2011 at 4:19 PM, Dave Young wrote: >> mtd/ram oops dumper will make more functions envolved. In case crash kexec, >> we should avoid kmsg dumper to ensure crashdump success. >> >> kill kmsg_dump callback while crash dumping > > https://lkml.org/lkml/2011/2/1/33 Thanks for give the link. So it's intend to be that. I'm still confused with the KMSG_DUMP_KEXEC. crash_kexec() kmsg_dump(KMSG_DUMP_KEXEC) kmsg_dump(KMSG_DUMP_PANIC) Looks like it's equal to original logic, isn't it? kmsg_dump(anything); crash_kexec() So why intruduce KMSG_DUMP_KEXEC? why not just kmsg_dump before crash_kexec? thoughts? -- Thanks Dave