From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54108)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1RTx2d-00088V-Pn
	for qemu-devel@nongnu.org; Fri, 25 Nov 2011 09:46:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1RTx2c-00060p-Sf
	for qemu-devel@nongnu.org; Fri, 25 Nov 2011 09:46:15 -0500
Received: from mel.act-europe.fr ([194.98.77.210]:44042)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1RTx2c-00060c-OQ
	for qemu-devel@nongnu.org; Fri, 25 Nov 2011 09:46:14 -0500
Message-ID: <4ECFAA34.6080309@adacore.com>
Date: Fri, 25 Nov 2011 15:46:12 +0100
From: Fabien Chouteau <chouteau@adacore.com>
MIME-Version: 1.0
References: <1314018774-27482-1-git-send-email-aliguori@us.ibm.com>	<1314018774-27482-2-git-send-email-aliguori@us.ibm.com>	<4E525C5A.8000208@redhat.com>
	<4E525D87.8010400@codemonkey.ws> <4E525E09.2000107@redhat.com>
	<4ECE7AA6.9070006@adacore.com> <4ECE7F38.4000704@redhat.com>
	<4ECF6CE7.3010800@adacore.com> <4ECF71FD.9090308@redhat.com>
In-Reply-To: <4ECF71FD.9090308@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to
 g_io_add_watch
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On 25/11/2011 11:46, Paolo Bonzini wrote:
> On 11/25/2011 11:24 AM, Fabien Chouteau wrote:
>>> For POSIX, it would be just a call to
>>> glib_select_fill+select+glib_select_poll.  (Everything around
>>> these three would stay in the caller, and the fd_sets would be
>>> passed to os_host_main_loop_wait).
>>
>> Are you sure we have to use select()?
> 
> slirp is fd_set---thus select()---based.  iohandler too, though it would likely be simpler to switch it to poll().

Right, for slirp and iohandler, but it seems wrong to take file
descriptors from g_main_context_query() and put them in the fd_sets for
select(). This part is still in the code today.

-- 
Fabien Chouteau