From: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
Cc: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"Grant Likely
(grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org)"
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: DT DMA channel binding for Tegra I2S
Date: Sat, 26 Nov 2011 22:07:01 -0600 [thread overview]
Message-ID: <4ED1B765.9070107@gmail.com> (raw)
In-Reply-To: <20111125160908.GF5315-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
Mark,
On 11/25/2011 10:09 AM, Mark Brown wrote:
> On Fri, Nov 25, 2011 at 09:55:23AM -0600, Rob Herring wrote:
>
>> Although, I think you are possibly missing some other properties for
>> i2s mode like word size and master/slave mode. I think the ideal case
>> is that a single ASoC platform driver for DT could handle multiple
>> SoCs.
>
> No. You're not going to be able to get a single binding which handles
> the setup for all systems based off a given SoC let alone multiple SoCs.
> It is possible to come up with some subsets which work over multiple
> boards but that's going to be outside the binding for the I2S controller
> and in a board audio hardware binding for the subset.
I never said a single binding. Part of device tree is describing how
devices are connected together which is a large part of the audio
configuration. Whether there's one common driver or not doesn't really
matter. The important part right now is to define the bindings and do so
in a common way where possible.
My original point really was that when defining a binding, it should be
as complete as possible rather than done incrementally over time. You
are describing the h/w, and that's not changing. For an i2s block, only
having a dma channel is definitely not complete.
> This has been discussed repeatedly, we really need to work out how to
> educate device tree people about this stuff, it gets *very* repetitive
> having the discussion over and over again.
As you might guess, audio is not an area I have been spending time on
recently. Perhaps seeing a complete binding with all the pieces (codec,
i2s, misc gpio's, etc.) would help educate us.
Rob
next prev parent reply other threads:[~2011-11-27 4:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 21:25 DT DMA channel binding for Tegra I2S Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF174F08C803-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-11-23 21:54 ` Rob Herring
[not found] ` <4ECD6BA4.1010607-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-11-23 23:26 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF174F08C881-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-11-25 15:55 ` Rob Herring
[not found] ` <CAL_JsqLk=ExaPoy9f3CqEthjZsu7CVmAwcckpk5PyJA-NhMGVA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-11-25 16:09 ` Mark Brown
[not found] ` <20111125160908.GF5315-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-11-27 4:07 ` Rob Herring [this message]
[not found] ` <4ED1B765.9070107-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-11-27 12:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED1B765.9070107@gmail.com \
--to=robherring2-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.