From: Felix Fietkau <nbd@openwrt.org>
To: Adrian Chadd <adrian@freebsd.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Senthil Balasubramanian <senthilb@qca.qualcomm.com>,
"Luis R. Rodriguez" <mcgrof@qca.qualcomm.com>,
"John W. Linville" <linville@tuxdriver.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath9k: Revert change that broke AR928X on Acer Ferrari One
Date: Sun, 27 Nov 2011 13:25:02 +0700 [thread overview]
Message-ID: <4ED1D7BE.7040401@openwrt.org> (raw)
In-Reply-To: <CAJ-Vmo=yh_maZtccaBkqZwip-ubjR4U471ALPwYwTurMaQrZ9Q@mail.gmail.com>
On 2011-11-27 8:16 AM, Adrian Chadd wrote:
> Hm, considering the origina patch did this:
>
> /* Clear Bit 14 of AR_WA after putting chip into Full Sleep mode. */
> - if (AR_SREV_9300_20_OR_LATER(ah))
> - REG_WRITE(ah, AR_WA,
> - ah->WARegVal & ~AR_WA_D3_L1_DISABLE);
> + if (!AR_SREV_9480(ah))
> + REG_WRITE(ah, AR_WA, ah->WARegVal & ~AR_WA_D3_L1_DISABLE);
>
> .. something tells me that perhaps the correct statement is:
>
> if (AR_SREV_9300_20_OR_LATER(ah) && !AR_SREV_9480(ah))
> REG_WRITE() ...
>
I checked again, the !AR_SREV_9480(ah) was intentionally removed in a
later change, so using AR_SREV_9300_20_OR_LATER(ah) is correct.
- Felix
next prev parent reply other threads:[~2011-11-27 6:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 4:58 Linux 3.2-rc3 - just in time for Thanksgiving Linus Torvalds
2011-11-25 1:03 ` Rafael J. Wysocki
2011-11-26 21:32 ` [Regression, 3.2-rc1] ath9k broken on AR928X (was: Re: Linux 3.2-rc3 - just in time for Thanksgiving) Rafael J. Wysocki
2011-11-26 21:54 ` Adrian Chadd
2011-11-26 22:37 ` [PATCH] ath9k: Revert change that broke AR928X on Acer Ferrari One Rafael J. Wysocki
2011-11-27 1:16 ` Adrian Chadd
2011-11-27 6:25 ` Felix Fietkau [this message]
2011-11-27 6:39 ` Adrian Chadd
2011-11-27 6:20 ` [Regression, 3.2-rc1] ath9k broken on AR928X Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED1D7BE.7040401@openwrt.org \
--to=nbd@openwrt.org \
--cc=adrian@freebsd.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@qca.qualcomm.com \
--cc=rjw@sisk.pl \
--cc=senthilb@qca.qualcomm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.