From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH_v2 1/4] cdmamodem: Add sim driver implementation
Date: Sun, 27 Nov 2011 06:02:33 -0600 [thread overview]
Message-ID: <4ED226D9.2070502@gmail.com> (raw)
In-Reply-To: <1321872845-24754-2-git-send-email-guillaume.zajac@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 585 bytes --]
Hi Guillaume,
On 11/21/2011 04:54 AM, Guillaume Zajac wrote:
> ---
> Makefile.am | 3 +-
> drivers/cdmamodem/cdmamodem.c | 2 +
> drivers/cdmamodem/cdmamodem.h | 3 +
> drivers/cdmamodem/sim.c | 582 +++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 589 insertions(+), 1 deletions(-)
> create mode 100644 drivers/cdmamodem/sim.c
>
I really don't like us copy-pasting this much code for no good reason.
Let me toy with a few ideas, but the obvious start would be to refactor
this code into a library.
Regards,
-Denis
next prev parent reply other threads:[~2011-11-27 12:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 10:54 [PATCH_v2 0/4] Use sim atom with cdma modems Guillaume Zajac
2011-11-21 10:54 ` [PATCH_v2 1/4] cdmamodem: Add sim driver implementation Guillaume Zajac
2011-11-27 12:02 ` Denis Kenzior [this message]
2011-11-29 14:20 ` Guillaume Zajac
2011-11-21 10:54 ` [PATCH_v2 2/4] simfs: Call callback with failure if driver is not implemented Guillaume Zajac
2011-11-27 12:04 ` Denis Kenzior
2011-11-21 10:54 ` [PATCH_v2 3/4] huaweicdma: Add SIM creation and set_online method driver Guillaume Zajac
2011-11-27 14:29 ` Denis Kenzior
2011-11-21 10:54 ` [PATCH_v2 4/4] sim: Get IMSI if sim state is OFONO_SIM_STATE_INSERTED Guillaume Zajac
2011-11-27 12:08 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED226D9.2070502@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.