From: Viresh Kumar <viresh.kumar@st.com>
To: Vinod Koul <vinod.koul@intel.com>, Dan <dan.j.williams@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Armando VISCONTI <armando.visconti@st.com>,
Shiraz HASHIM <shiraz.hashim@st.com>,
Vipin KUMAR <vipin.kumar@st.com>,
Rajeev KUMAR <rajeev-dlh.kumar@st.com>,
Deepak SIKRI <deepak.sikri@st.com>,
Vipul Kumar SAMAR <vipulkumar.samar@st.com>,
Amit VIRDI <Amit.VIRDI@st.com>,
Pratyush ANAND <pratyush.anand@st.com>,
Bhupesh SHARMA <bhupesh.sharma@st.com>,
"viresh.linux@gmail.com" <viresh.linux@gmail.com>,
Bhavna YADAV <bhavna.yadav@st.com>
Subject: Re: [PATCH 1/3] dmaengine: Allow controller drivers to set channel ids
Date: Mon, 28 Nov 2011 09:35:39 +0530 [thread overview]
Message-ID: <4ED30893.6080601@st.com> (raw)
In-Reply-To: <1317200887.1573.1768.camel@vkoul-udesk3>
On 9/28/2011 2:38 PM, Vinod Koul wrote:
> On Thu, 2011-09-22 at 16:13 +0530, Viresh Kumar wrote:
>> > Currently value of chan_id field is updated by dmaengine.c while the dma device
>> > is registered. In some cases the controller driver may need to assign channel
>> > numbers by itself. For example, dw_dmac.c wants to control the order in which
>> > channels are allocated by dmaengine. So it added channels inside channel list of
>> > dma_device in reverse order. Now channel 7 is allocated first and channel 0 is
>> > allocated last.
>> >
>> > But as the channel ids are updated by dmaengine, channel numbers in sysfs will
>> > be overwritten if controller has added channels in reverse order. To represent
>> > correct channel number in sysfs, it is required that dmaengine must not assume
>> > that first channel in list is channel 0 and last is 7.
> to dmaengine, this is just a channel representation in sysfs and nothing
> more. If damc is assuming that this is same as what dmaengine will do
> then dmac is wrong.
>
> Nevertheless, Dan was okay with changing this representation.
> Dan I would need your comments/Ack before we discuss this further
Dan/Vinod,
Any feedback on this patchset?
--
viresh
prev parent reply other threads:[~2011-11-28 4:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-22 10:43 [PATCH 1/3] dmaengine: Allow controller drivers to set channel ids Viresh Kumar
2011-09-22 10:43 ` [PATCH 2/3] dmaengine/dw_dmac: Set channel id's in controller driver Viresh Kumar
2011-09-22 10:43 ` [PATCH 3/3] dmaengine/dw_dmac: Don't use magic number for total number of channels Viresh Kumar
2011-09-28 9:08 ` [PATCH 1/3] dmaengine: Allow controller drivers to set channel ids Vinod Koul
2011-10-13 8:46 ` Viresh Kumar
2011-10-14 5:43 ` Vinod Koul
2011-10-31 10:22 ` Viresh Kumar
2011-11-16 11:41 ` Viresh Kumar
2011-11-28 4:05 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED30893.6080601@st.com \
--to=viresh.kumar@st.com \
--cc=Amit.VIRDI@st.com \
--cc=armando.visconti@st.com \
--cc=bhavna.yadav@st.com \
--cc=bhupesh.sharma@st.com \
--cc=dan.j.williams@intel.com \
--cc=deepak.sikri@st.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pratyush.anand@st.com \
--cc=rajeev-dlh.kumar@st.com \
--cc=shiraz.hashim@st.com \
--cc=vinod.koul@intel.com \
--cc=vipin.kumar@st.com \
--cc=vipulkumar.samar@st.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.