From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Keir Fraser <keir.xen@gmail.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Unaligned writes on the kexec path
Date: Mon, 28 Nov 2011 14:24:39 +0000 [thread overview]
Message-ID: <4ED399A7.1070108@citrix.com> (raw)
Hello,
In c/s 7493bb48d89f, you change the internals of kexec_crash_save_info()
to reduce unaligned writes, but pass the resulting pointer back to
machine_crash_shutdown() which performs writes on the possibly unaligned
data structure. There are also plenty of other writes on the kexec path
which are possibly or certainly unaligned.
What is the reason for wanting to reduce unaligned writes?
Would a better solution be to just ensure that the crash note itself is
properly aligned?
--
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com
next reply other threads:[~2011-11-28 14:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 14:24 Andrew Cooper [this message]
2011-11-28 20:42 ` Unaligned writes on the kexec path Keir Fraser
2011-11-29 5:51 ` Simon Horman
2011-11-29 10:49 ` Andrew Cooper
2011-11-29 11:35 ` Jan Beulich
2011-11-29 12:54 ` Andrew Cooper
2011-12-01 3:00 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED399A7.1070108@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=keir.xen@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.