All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: acme@ghostprotocols.net
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
	peterz@infradead.org, fweisbec@gmail.com
Subject: Re: [PATCH] perf tool: reset use_browser when compiled without NEWT
Date: Mon, 28 Nov 2011 09:58:46 -0700	[thread overview]
Message-ID: <4ED3BDC6.2080104@gmail.com> (raw)
In-Reply-To: <1321913788-2867-1-git-send-email-dsahern@gmail.com>

Hi Arnaldo:

didn't see this one in your queue or a response. Do you agree this is
needed?

On 11/21/2011 03:16 PM, David Ahern wrote:
> e.g.,  when using
>   make NO_NEWT=yes ...
> or if newt-devel is not installed
> 
> Signed-off-by: David Ahern <dsahern@gmail.com>
> ---
>  tools/perf/util/cache.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/tools/perf/util/cache.h b/tools/perf/util/cache.h
> index fc5e5a0..9d7612a 100644
> --- a/tools/perf/util/cache.h
> +++ b/tools/perf/util/cache.h
> @@ -36,6 +36,7 @@ extern int use_browser;
>  #ifdef NO_NEWT_SUPPORT
>  static inline void setup_browser(bool fallback_to_pager)
>  {
> +	use_browser = 0;
>  	if (fallback_to_pager)
>  		setup_pager();
>  }

  reply	other threads:[~2011-11-28 16:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-21 22:16 [PATCH] perf tool: reset use_browser when compiled without NEWT David Ahern
2011-11-28 16:58 ` David Ahern [this message]
2011-11-28 17:09   ` Arnaldo Carvalho de Melo
2011-11-28 17:16     ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ED3BDC6.2080104@gmail.com \
    --to=dsahern@gmail.com \
    --cc=acme@ghostprotocols.net \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.