All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rick Jones <rick.jones2@hp.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "Пламен Петров" <plamen.sisi@gmail.com>,
	"David Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org
Subject: Re: [NET][TG3] Fwd: page allocation failure with linux 3.1.1
Date: Mon, 28 Nov 2011 11:05:53 -0800	[thread overview]
Message-ID: <4ED3DB91.9090409@hp.com> (raw)
In-Reply-To: <1322468762.2826.17.camel@edumazet-laptop>

On 11/28/2011 12:26 AM, Eric Dumazet wrote:
> Le lundi 28 novembre 2011 à 09:16 +0200, Пламен Петров a écrit :
>
>> Well, Eric, thanks for the explanation! I will disable TSO and will
>> see how is that working out for me - if I recall correctly, I had no
>> problems when TSO was off.
>>
>> Sorry to bother you, if the above explanation was somewhere readily
>> available, but I didn't manage to find it.
>
> You dont bother me at all :)
>
> As a matter of fact, your mail reminded me something I wanted to do in
> the past and forgot about.
>
> Since some devices might copy skb to a linear one in their
> ndo_start_xmit(), we could set a netdev limit so that TSO can still be
> used on these devices, but limiting number of frags to
> 2^PAGE_ALLOC_COSTLY_ORDER

How much "TSO value" remains after such a copy?

rick jones

>
> (Since PAGE_ALLOC_COSTLY_ORDER == 3, thats 8 frags, instead of 16 right
> now on x86)
>
> Of course, if memory is really tight, even an ATOMIC order-3 allocation
> might fail. If this happens, device limit could be dynamically
> decreased. In the end, only linear skb could be built by TCP.
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2011-11-28 19:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-27 14:25 page allocation failure with linux 3.1.1 Пламен Петров
2011-11-27 20:34 ` [NET][TG3] Fwd: " Пламен Петров
2011-11-28  6:35   ` Eric Dumazet
2011-11-28  7:16     ` Пламен Петров
2011-11-28  8:26       ` Eric Dumazet
2011-11-28 19:05         ` Rick Jones [this message]
2011-11-28 19:28           ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ED3DB91.9090409@hp.com \
    --to=rick.jones2@hp.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=plamen.sisi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.