Re: [Qemu-devel] [PATCH v4] configure: avoid screening of --{en, dis}able-usb-redir options

[Anthony Liguori <anthony@codemonkey.ws>]

On 11/24/2011 06:11 AM, Max Filippov wrote:
> --*dir) option pattern precede --{en,dis}able-usb-redir) patterns in the
> option analysis switch, making the latter options have no effect.
>
> There were some --*dir that are supported by Autoconf and not by QEMU configure.
> The aim was to let QEMU packagers use the rpm (or similar) macro that overrides
> directories for their distribution.
>
> Replace --*dir with exact option names.
>
> Signed-off-by: Max Filippov<jcmvbkbc@gmail.com>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
> v2 ->  v3 changes: add --htmldir
> v3 ->  v4 changes: collapse cases, include rationale into the configure
> ---
>   configure |   10 ++++++++--
>   1 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index f033438..60c3740 100755
> --- a/configure
> +++ b/configure
> @@ -569,6 +569,14 @@ for opt do
>     ;;
>     --sysconfdir=*) sysconfdir="$optarg"
>     ;;
> +  --sbindir=*|--libexecdir=*|--sharedstatedir=*|--localstatedir=*|\
> +  --oldincludedir=*|--datarootdir=*|--infodir=*|--localedir=*|\
> +  --htmldir=*|--dvidir=*|--pdfdir=*|--psdir=*)
> +    # These switches are silently ignored, for compatibility with
> +    # autoconf-generated configure scripts. This allows QEMU's
> +    # configure to be used by RPM and similar macros that set
> +    # lots of directory switches by default.
> +  ;;
>     --disable-sdl) sdl="no"
>     ;;
>     --enable-sdl) sdl="yes"
> @@ -759,8 +767,6 @@ for opt do
>     ;;
>     --enable-opengl) opengl="yes"
>     ;;
> -  --*dir)
> -  ;;
>     --disable-rbd) rbd="no"
>     ;;
>     --enable-rbd) rbd="yes"